Hello Adam, –– The z3c.pt package shouldn't have difficult dependencies; it depends on zope.i18n >= 3.5 but reasons unknown to me (Hanno CC'ed). Note that the package no longer depends on ``lxml``. \malthe
Hi. Malthe Borch wrote:
The z3c.pt package shouldn't have difficult dependencies; it depends on zope.i18n >= 3.5 but reasons unknown to me (Hanno CC'ed).
The zope.i18n 3.5 dependency is used for the optimized i18n support in Chameleon. I ported all the performance tweaks we made in Plone and PlacelessTranslationService over time back to zope.i18n in that release. Chameleon uses the zope.i18n.negotiate function added in 3.5 to negotiate the language once per template instead of in every zope.i18n.translate call. It works with a special fast_translate function that skips the negotiation step completely and relies on the negotiate function instead. While zope.i18n 3.5 is not part of the 3.4 KGS it's way older then the final 3.4 KGS release and only introduces backwards compatible new features. Hanno
Hello Malthe, Well, the strong target is to make z3c.form 2.0 compatible with KGS 3.4. (z3c.pt is somehow intertwined with z3c.ptcompat too.) That's the goal am chasing though I'm quite busy right now. Wednesday, May 20, 2009, 9:28:33 AM, you wrote: MB> Hello Adam, –– MB> The z3c.pt package shouldn't have difficult dependencies; it depends on zope.i18n >>= 3.5 but reasons unknown to me (Hanno CC'ed). MB> Note that the package no longer depends on ``lxml``. MB> \malthe MB> _______________________________________________ MB> Zope-Dev maillist - Zope-Dev@zope.org MB> http://mail.zope.org/mailman/listinfo/zope-dev MB> ** No cross posts or HTML encoding! ** MB> (Related lists - MB> http://mail.zope.org/mailman/listinfo/zope-announce MB> http://mail.zope.org/mailman/listinfo/zope ) -- Best regards, Adam GROSZER mailto:agroszer@gmail.com -- Quote of the day: If you want to know how old a man is, ask his brother-in-law.
2009/5/21 Adam GROSZER <agroszer@gmail.com>:
Well, the strong target is to make z3c.form 2.0 compatible with KGS 3.4. (z3c.pt is somehow intertwined with z3c.ptcompat too.) That's the goal am chasing though I'm quite busy right now.
I don't know the implications of requiring zope.i18n >= 3.5, but I can say that it's the only dependency that could somehow cause difficulties. Neither z3c.pt nor z3c.ptcompat have any odd dependencies (package or version-wise). Perhaps it's the obsolete dependency on lxml that's causing confusion; I read a post or two on the list rightfully mentioning that this was a very difficult dependency indeed. I think at this point that z3c.form could have a strong dependency on z3c.pt. Complete list of extra packages: - z3c.pt - chameleon.core - chameleon.zpt - sourcecodegen \malthe
On May 21, 2009, at 1:10 AM, Malthe Borch wrote:
I think at this point that z3c.form could have a strong dependency on z3c.pt. Complete list of extra packages:
Won't this cause problems if a z3c.form uses a template which calls a macro from a traditional Zope page template? That is, make it impossible to use z3c.form in a site that isn't using z3c.pt for everything? David Glick Web Developer ONE/Northwest New tools and strategies for engaging people in protecting the environment http://www.onenw.org davidglick@onenw.org work: (206) 286-1235 x32 mobile: (206) 679-3833 Subscribe to ONEList, our email newsletter! Practical advice for effective online engagement http://www.onenw.org/full_signup
2009/5/21 David Glick <davidglick@onenw.org>:
Won't this cause problems if a z3c.form uses a template which calls a macro from a traditional Zope page template? That is, make it impossible to use z3c.form in a site that isn't using z3c.pt for everything?
That was the reason for z3c.ptcompat; it lets you use one import-location to switch between the two implementations. \malthe
On May 21, 2009, at 11:09 PM, Malthe Borch wrote:
2009/5/21 David Glick <davidglick@onenw.org>:
Won't this cause problems if a z3c.form uses a template which calls a macro from a traditional Zope page template? That is, make it impossible to use z3c.form in a site that isn't using z3c.pt for everything?
That was the reason for z3c.ptcompat; it lets you use one import-location to switch between the two implementations.
Ah, right...I was remembering incorrectly why we were unable to use z3c.ptcompat from within Plone. The actual reason is that it uses ViewPageTemplateFile from z3c.pt when we need it from five.pt (I think...it's been a while). But we were able to work around that by adjusting the custom form and widget template factories in plone.z3cform David Glick Web Developer ONE/Northwest New tools and strategies for engaging people in protecting the environment http://www.onenw.org davidglick@onenw.org work: (206) 286-1235 x32 mobile: (206) 679-3833 Subscribe to ONEList, our email newsletter! Practical advice for effective online engagement http://www.onenw.org/full_signup
Hello Malthe, The problem that I see here with lxml is that it is used for output checking. Even worse z3c.form requires at least 2.1.1 of lxml, where KGS 3.4 has lxml nailed at 1.3.6. This burpes already on buildout. Now even if I would ignore this requirement for testing, (and testing) how could I be sure that tests pass (with KGS 3.4)? Take a look at svn://svn.zope.org/repos/main/z3c.form/branches/adamg-z3c-pt-optional and try to make the tests work and pass. Look out, buildout.cfg has the KGS temporarily. Thursday, May 21, 2009, 10:10:33 AM, you wrote: MB> 2009/5/21 Adam GROSZER <agroszer@gmail.com>:
Well, the strong target is to make z3c.form 2.0 compatible with KGS 3.4. (z3c.pt is somehow intertwined with z3c.ptcompat too.) That's the goal am chasing though I'm quite busy right now.
MB> I don't know the implications of requiring zope.i18n >= 3.5, but I can MB> say that it's the only dependency that could somehow cause MB> difficulties. Neither z3c.pt nor z3c.ptcompat have any odd MB> dependencies (package or version-wise). MB> Perhaps it's the obsolete dependency on lxml that's causing confusion; MB> I read a post or two on the list rightfully mentioning that this was a MB> very difficult dependency indeed. MB> I think at this point that z3c.form could have a strong dependency on MB> z3c.pt. Complete list of extra packages: MB> - z3c.pt MB> - chameleon.core MB> - chameleon.zpt MB> - sourcecodegen MB> \malthe MB> _______________________________________________ MB> Zope-Dev maillist - Zope-Dev@zope.org MB> http://mail.zope.org/mailman/listinfo/zope-dev MB> ** No cross posts or HTML encoding! ** MB> (Related lists - MB> http://mail.zope.org/mailman/listinfo/zope-announce MB> http://mail.zope.org/mailman/listinfo/zope ) -- Best regards, Adam GROSZER mailto:agroszer@gmail.com
2009/5/23 Adam GROSZER <agroszer@gmail.com>:
The problem that I see here with lxml is that it is used for output checking. Even worse z3c.form requires at least 2.1.1 of lxml, where KGS 3.4 has lxml nailed at 1.3.6.
It might be possible to shed this testing dependency; ``lxml`` is used because of its doctest-mode, but since then, Chameleon has been equipped to render attributes in the ZPT order (instead of more or less random). This was the raison d'etre to use lxml in tests.
This burpes already on buildout. Now even if I would ignore this requirement for testing, (and testing) how could I be sure that tests pass (with KGS 3.4)?
Yes, I agree with that observation. \malthe
Hello Malthe, Tiny problem is that the doctests seem to have the attributes in lxml-sane order. That means just by removing lxml output-sanitization even zpt output does not match the doctest. Also, lxml is used to do some xpath queries. Saturday, May 23, 2009, 10:23:16 AM, you wrote: MB> 2009/5/23 Adam GROSZER <agroszer@gmail.com>:
The problem that I see here with lxml is that it is used for output checking. Even worse z3c.form requires at least 2.1.1 of lxml, where KGS 3.4 has lxml nailed at 1.3.6.
MB> It might be possible to shed this testing dependency; ``lxml`` is used MB> because of its doctest-mode, but since then, Chameleon has been MB> equipped to render attributes in the ZPT order (instead of more or MB> less random). This was the raison d'etre to use lxml in tests.
This burpes already on buildout. Now even if I would ignore this requirement for testing, (and testing) how could I be sure that tests pass (with KGS 3.4)?
MB> Yes, I agree with that observation. MB> \malthe MB> _______________________________________________ MB> Zope-Dev maillist - Zope-Dev@zope.org MB> http://mail.zope.org/mailman/listinfo/zope-dev MB> ** No cross posts or HTML encoding! ** MB> (Related lists - MB> http://mail.zope.org/mailman/listinfo/zope-announce MB> http://mail.zope.org/mailman/listinfo/zope ) -- Best regards, Adam GROSZER mailto:agroszer@gmail.com -- Quote of the day: What reason have atheists for saying that we cannot rise again? Which is more difficult: to be born, or to rise again? That what has never been should be, or that what has been should be again? Is it more difficult to come into being than to return to it? - Blaise Pascal
participants (4)
-
Adam GROSZER -
David Glick -
Hanno Schlichting -
Malthe Borch