Proposal: Remove the dependency of zope.app.exception on zope.formlib
Hi, zope.app.exception depends on zope.formlib to use the NamedTemplate for the Unauthorized view. As zope.formlib has many dependencies I propose to depend on z3c.template to get a named template. (Even z3c.layer.pagelet depends on zope.app.exception (for the Unauthorized view) and so it depends on zope.formlib.) I implemented the proposal in svn+ssh://svn.zope.org/repos/main/ zope.app.exception/branches/icemac_no_formlib (I also added a minimized patch of my changes to this e-mail.) Any comments on this implementation? Should I do the include <include package="z3c.template" file="meta.zcml" /> in zope.app.exception's configure.zcml or only in the ftesting.zcml? Yours sincerely, -- Michael Howitz · mh@gocept.com · software developer gocept gmbh & co. kg · forsterstraße 29 · 06112 halle (saale) · germany http://gocept.com · tel +49 345 1229889 8 · fax +49 345 1229889 1 Zope and Plone consulting and development
On Tuesday 07 April 2009, Michael Howitz wrote:
Any comments on this implementation?
+1 from me, since I hate having zope.formlib around. However, this might be self-serving and we should hear from people not using newer UI patterns.
Should I do the include <include package="z3c.template" file="meta.zcml" /> in zope.app.exception's configure.zcml or only in the ftesting.zcml?
Just in ftesting.zcml should be fine in my opinion. Regards, Stephan -- Stephan Richter Web Software Design, Development and Training Google me. "Zope Stephan Richter"
On Tue, 2009-04-07 at 21:38 -0700, Stephan Richter wrote:
On Tuesday 07 April 2009, Michael Howitz wrote:
Any comments on this implementation?
+1 from me, since I hate having zope.formlib around. However, this might be self-serving and we should hear from people not using newer UI patterns.
Should I do the include <include package="z3c.template" file="meta.zcml" /> in zope.app.exception's configure.zcml or only in the ftesting.zcml?
Just in ftesting.zcml should be fine in my opinion.
Honestly, I'm having trouble arguing for either scenario exclusively. I'm somewhat expecting that doing <include package="xy"/> will cause this package to do everything it needs to activate its configuration. E.g. z3c.form is partially painful because one has to do the same work over and over again in figuring out which depending libraries need to be configured. -- Christian Theune · ct@gocept.com gocept gmbh & co. kg · forsterstraße 29 · 06112 halle (saale) · germany http://gocept.com · tel +49 345 1229889 7 · fax +49 345 1229889 1 Zope and Plone consulting and development
On Thursday 23 April 2009, Christian Theune wrote:
E.g. z3c.form is partially painful because one has to do the same work over and over again in figuring out which depending libraries need to be configured.
Good point. We should probably provide a sample configuration somewhere. Regards, Stephan -- Stephan Richter Web Software Design, Development and Training Google me. "Zope Stephan Richter"
Am 07.04.2009 um 20:39 schrieb Michael Howitz:
Hi,
zope.app.exception depends on zope.formlib to use the NamedTemplate for the Unauthorized view. As zope.formlib has many dependencies I propose to depend on z3c.template to get a named template. (Even z3c.layer.pagelet depends on zope.app.exception (for the Unauthorized view) and so it depends on zope.formlib.)
I implemented the proposal in svn+ssh://svn.zope.org/repos/main/ zope.app.exception/branches/icemac_no_formlib (I also added a minimized patch of my changes to this e-mail.)
Any comments on this implementation?
As there where no further comments besides the one of Stefan Richter, I'll merge the proposed changes soon and do a new release. Yours sincerely, -- Michael Howitz · mh@gocept.com · software developer gocept gmbh & co. kg · forsterstraße 29 · 06112 halle (saale) · germany http://gocept.com · tel +49 345 1229889 8 · fax +49 345 1229889 1 Zope and Plone consulting and development
participants (3)
-
Christian Theune -
Michael Howitz -
Stephan Richter