-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 01/08/2011 05:58 AM, Jens Vagelpohl wrote:
On 1/7/11 22:28 , William Heymann wrote:
I have a monkey patch here that I would like comments on it and to see how it works for others.
Hi William,
A huge monkey patch like that makes it very hard to compare it with the original implementation and see the actual changes. You could help the review *greatly* by providing a diff to the original implementation instead, and post that to the Zope bug tracker on Launchpad:
The developer docs help explain how to create such a patch as a non-committer: in particular: http://docs.zope.org/developer/noncommitter-svn.html shows how to use SVN to generate the patch without needing write access. Tres. - -- =================================================================== Tres Seaver +1 540-429-0999 tseaver@palladion.com Palladion Software "Excellence by Design" http://palladion.com -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk0omvYACgkQ+gerLs4ltQ5aLACeJTsnaKuyRAi6uEnFePwBR+eP YzgAn1P7M20BpM2/H5JncUFv7QLhCgSZ =Xfvp -----END PGP SIGNATURE-----