Important Fix for Zope 2.0 through 2.1.6
Thanks to Jeff Ragsdale, we've finally been able to kill a longstanding bug that allows POST requests to interfere with each other. Symptoms include corrupted or aborted File and Image uploads, and stupid-log messages about "AttributeError: data" killing threads. The attached HTTPServer.py is valid for all Zope 2.0.x and 2.1.x versions. I am posting the patched file for Zope 2.2.x separately. PLEASE BACK UP <Zope>/ZServer/HTTPServer.py, then replace it with the attached file. Cheers, Evan @ digicool & 4-am
Evan Simpson wrote:
Thanks to Jeff Ragsdale, we've finally been able to kill a longstanding bug that allows POST requests to interfere with each other. Symptoms include corrupted or aborted File and Image uploads, and stupid-log messages about "AttributeError: data" killing threads.
Could something similar be happening in PCGIServer too ? We are getting some weird and hard-to-reproduce errors when activity goes up and several file uploads are going on simultaneously? --------------- Hannu
From: "Hannu Krosing" <hannu@tm.ee>
Could something similar be happening in PCGIServer too ?
We are getting some weird and hard-to-reproduce errors when activity goes up and several file uploads are going on simultaneously?
I'm not sure. I've peeked at the code, and the exact same bug doesn't seem to be at work. One way to tell is to create two File objects, open their Upload tab in side-by-side browser windows, choose the same long file (>1MB is good) in both windows, then start the uploads together (as close as you can manage). Next, change one of the windows into a Folder add form (any form will do, really). Now start the large file upload, then quickly submit the add form. If there is a similar bug in PCGIServer, the first experiment will give you a corrupted File (wrong size) and a weird log entry, and the second should kill a thread with an "AttributeError:data" log entry. Cheers, Evan @ digicool & 4-am
participants (2)
-
Evan Simpson -
Hannu Krosing