Re: [Zope] FSZSQLMethod.py refactory
On 22 Jul 2005, at 17:17, Jean Rodrigo Ferri wrote:
Jens Vagelpohl wrote:
It does work.
How? Give me an example!
Take a look at the unit tests which exercise the FSZSQL code, there is a sample one that is part of the fake skins directory used by the CMFCore unit tests: http://svn.zope.org/CMF/trunk/CMFCore/tests/fake_skins/fake_skin/ testsql.zsql?rev=37165&view=markup
I can't give this information because it doesn't raise exceptions. It works (not raise errors), but not properly.
I never saw an example of ZSQL Methods running from file system in CMF, can you give me this?
My intention is just contribute, however, solving a real problem I have.
You're still giving no clue about what exactly it is that works "not properly". jens
Jens Vagelpohl wrote: [...]
You're still giving no clue about what exactly it is that works "not properly".
I looked at your example and I understood the correct sintax, now it make sence, the <dtml-comment> comments the attributes in the body of ZSQLMethod. But in my refactory of parser I used a more elegant sintax to the file like Script Python, and does not leave the trash (<dtml-comment> arguments </dtml-comment>) in the body of the method. I only wait that someone test my reimplementation of parser and says me it's really insignificant. I would like at least not to have that trash (<dtml-comment>...) in the body of the method. Regards! -- Jean Ferri
I only wait that someone test my reimplementation of parser and says me it's really insignificant.
I would like at least not to have that trash (<dtml-comment>...) in the body of the method.
As far as the CMF goes, IMHO it doesn't make much sense to put code into the repository just because one person doesn't like the way arguments are handed to these ZSQL methods. They work perfectly as is. I fail to see how several lines of double-hash-escaped lines is any less "trash" than the comment-tagged version that is there right now. jens
participants (2)
-
Jean Rodrigo Ferri -
Jens Vagelpohl