Re: [Zope] Caching on-the-fly resized photos (implemented)
Ron, I downloaded V1.22 and installed it and did run upgrade one a site with some 1000 photos. Everything worked fine. I found a small bug. In editSettingsForm.dtml you are using store unconditionally. I do have photos without store (dont know why) that do not like such a form. Now for a totally differnt matter. I need Photo translated into at least french and german. As you know, Zope does not really hinder translation but that is about all the help one gets in that realm. I would suggest to add a primitive translation support to Photo. What I have in mind is that every source file has a from translate import translate added. translate in its simplest incarnation does nothing but return its input. In Photo for every string meant to be seen in the user interface one would call translate with that string. Somebody who wants to have Photo translated would provide an appropriate translate function. I would happyly do this adaptation of your code. However we should find a way how to have it merged into your code stream. Robert
-----Original Message----- From: Robert Rottermann [mailto:robert@redcor.ch]
I downloaded V1.22 and installed it and did run upgrade one a site with some 1000 photos. Everything worked fine.
Glad to hear that.
I found a small bug. In editSettingsForm.dtml you are using store unconditionally. I do have photos without store (dont know why) that do not like such a form.
Hmmm... Every photo should have a store. Part of the upgrade method is supposed to give the proper store setting since prior versions didn't keep the store. Could you export some of your photos that don't have a store and let me take a look? Also, if you could let me know what version they were created with, that would help. Are they in Photo Folders, or just by themselves?
I would suggest to add a primitive translation support to Photo.
I would happyly do this adaptation of your code. However we should find a way how to have it merged into your code stream.
I don't have any ideas on how best to implement this, so if you want to provide me with some diffs to the current version that implements your ideas, I'll be happy to take a look at it. If you want to just do a portion before diving in to do the whole thing, that would be great. Thanks for your feedback! _______________________ Ron Bickers Logic Etc, Inc.
Here is a folder with a coupple of photos that have no store. I do not know exactly from what version they have been created 1.1 or earlier. However they where added programatically. I uploaded them by help of a zip file of images and "converting" them to photos afterwards. It looks like photos that where created before V 1.2 do not have the store, even after running upgrade. Re translation: Tomorrow I will send you some diffs. Robert
participants (2)
-
Robert Rottermann -
Ron Bickers