Re: [Zope-Checkins] CVS: Zope/lib/python/OFS - ObjectManager.py:1.163.12.4
Zachery Bir wrote:
On Mar 17, 2004, at 5:32 AM, Stefan H. Holek wrote:
Zachery,
Just at first glance, once you use getId() you can no longer compare to the string 'Anonymous User' because this is, well, the user's *name*. The anon user has an Id of 'None', IIRC.
And I am all with ChrisW wrt to missing tests...
Forthcoming. sorry.
Did you even RUN the existing test suite to make sure you hadn't broken anything before you made these checkins?! Chris -- Simplistix - Content Management, Zope & Python Consulting - http://www.simplistix.co.uk
On Wed, 2004-03-17 at 08:00, Chris Withers wrote:
Did you even RUN the existing test suite to make sure you hadn't broken anything before you made these checkins?!
If he did, it wouldn't have told him anything was wrong. All related tests passed last night, at least on the 2.7 branch. Please try not to get too indignant here. - C
Chris McDonough wrote:
If he did, it wouldn't have told him anything was wrong. All related tests passed last night, at least on the 2.7 branch. Please try not to get too indignant here.
*bah* lack of test coverage *humbug* ;-) Chris -- Simplistix - Content Management, Zope & Python Consulting - http://www.simplistix.co.uk
On Mar 17, 2004, at 8:00 AM, Chris Withers wrote:
Zachery Bir wrote:
On Mar 17, 2004, at 5:32 AM, Stefan H. Holek wrote:
Zachery,
Just at first glance, once you use getId() you can no longer compare to the string 'Anonymous User' because this is, well, the user's *name*. The anon user has an Id of 'None', IIRC.
And I am all with ChrisW wrt to missing tests... Forthcoming. sorry.
Did you even RUN the existing test suite to make sure you hadn't broken anything before you made these checkins?!
Yes, I did. Both with and without changes. Zac
participants (3)
-
Chris McDonough -
Chris Withers -
Zachery Bir