[CMF-checkins] CVS: CMF/CMFCore - CatalogTool.py:1.33

Shane Hathaway shane@zope.com
Thu, 01 Aug 2002 00:59:57 -0400


Florent Guillaume wrote:
> The problem with your changes is that we depend on the value []: Deep
> inside ZCatalog.Catalog.Catalog we have this code:
> 
>         if idxs==[]: use_indexes = self.indexes.keys()
>         else:        use_indexes = idxs
> 
> So please revert.

Actually I think the catalog needs to be fixed.  It should say "if not 
idxs" and should also use a tuple for the default argument.

Not long after this email, you reverted this checkin.  *Please* don't 
revert checkins without contacting and receiving a response from the 
author.  I don't receive email sent to cvs.zope.org.

Shane