[CMF-checkins] CVS: CMF/CMFCore - CatalogTool.py:1.33

[Florent Guillaume]

On Thu, 2002-08-01 at 06:59, Shane Hathaway wrote:
> Florent Guillaume wrote:
> > The problem with your changes is that we depend on the value []: Deep
> > inside ZCatalog.Catalog.Catalog we have this code:
> > 
> >         if idxs==[]: use_indexes = self.indexes.keys()
> >         else:        use_indexes = idxs
> > 
> > So please revert.
> 
> Actually I think the catalog needs to be fixed.  It should say "if not 
> idxs" and should also use a tuple for the default argument.
> 
> Not long after this email, you reverted this checkin.  *Please* don't 
> revert checkins without contacting and receiving a response from the 
> author.  I don't receive email sent to cvs.zope.org.

Sorry but when I replied to the checkin message, it actually went to
shane@cvs.zope.org (there is a misconfiguration somewhere) and you
didn't get it.

Also I had good reasons for reverting that chunk: you changed some code
that I wrote and was well-tested, and after your changes a test related
to indexing failed (CMFCore/tests/test_PortalFolder.py). I had other
changes to checkin and needed working tests.

Finally I agree that the catalog needs to be fixed, but that's in core
Zope and this is CMF so we have to be careful to be backwards
compatible.


Florent


-- 
Florent Guillaume, Nuxeo (Paris, France)
+33 1 40 33 79 87  http://nuxeo.com  mailto:fg@nuxeo.com