[CMF-checkins] CVS: CMF/CMFCore - CatalogTool.py:1.33

[Shane Hathaway]

Florent Guillaume wrote:
> Sorry but when I replied to the checkin message, it actually went to
> shane@cvs.zope.org (there is a misconfiguration somewhere) and you
> didn't get it.

I would consider anything@cvs.zope.org to be a bitbucket. :-)

> Also I had good reasons for reverting that chunk: you changed some code
> that I wrote and was well-tested, and after your changes a test related
> to indexing failed (CMFCore/tests/test_PortalFolder.py). I had other
> changes to checkin and needed working tests.
> 
> Finally I agree that the catalog needs to be fixed, but that's in core
> Zope and this is CMF so we have to be careful to be backwards
> compatible.

I understand.  You must also understand that I was once responsible for 
this module. :-)  You may have had the best of intentions, but you 
really must not revert a change without getting a response from the 
author, even if you have to delay a checkin.  I would have been happy to 
allow it if you had just asked first.  Please be courteous.

Shane