[ZODB-Dev] Re: [Zodb-checkins] SVN: ZODB/branches/3.4/src/ Added savepoints!

[Florent Guillaume]

Jim Fulton wrote:
>>> +    def tpc_begin(transaction):
>>> +        """Begin commit of a transaction, starting the two-phase
>>> commit.
>>> +
>>> +        transaction is the ITransaction instance associated with the
>>> +        transaction being committed.
>>> +
>>> +        subtransaction is a Boolean flag indicating whether the
>>> +        two-phase commit is being invoked for a subtransaction.
>>> +
>>> +        Important note: Subtransactions are modelled in the sense that
>>> +        when you commit a subtransaction, subsequent commits should be
>>> +        for subtransactions as well.  That is, there must be a
>>> +        commit_sub() call between a tpc_begin() call with the
>>> +        subtransaction flag set to true and a tpc_begin() with the
>>> +        flag set to false.
>>> +
>>> +        """
>>
>> But there's not "subtransaction" flag for this method anymore.
> 
> Right.  Are you worried that this is a backward compatibility issue?

No no, I was just worried about the inconsistency between the signature,
that has no 'subtransaction' arg, and the docstring that talks about one.

Florent

> This is a point that I didn't think of.  However, I wonder if this
> will be a problem.  Many old data managers seem to accept a single
> argument.  It's hard to imagine someone actualy writing a data
> manager that supports subtransactions.
> 
> Perhaps we need to send a query to zodb-dev and zope-dev.


-- 
Florent Guillaume, Nuxeo (Paris, France)   CTO, Director of R&D
+33 1 40 33 71 59   http://nuxeo.com   fg at nuxeo.com