[ZODB-Dev] Re: [Zodb-checkins] SVN: ZODB/branches/3.4/src/ Added savepoints!

[Jim Fulton]

Florent Guillaume wrote:
> Jim Fulton wrote:
> 
>>>>+    def tpc_begin(transaction):
>>>>+        """Begin commit of a transaction, starting the two-phase
>>>>commit.
>>>>+
>>>>+        transaction is the ITransaction instance associated with the
>>>>+        transaction being committed.
>>>>+
>>>>+        subtransaction is a Boolean flag indicating whether the
>>>>+        two-phase commit is being invoked for a subtransaction.
>>>>+
>>>>+        Important note: Subtransactions are modelled in the sense that
>>>>+        when you commit a subtransaction, subsequent commits should be
>>>>+        for subtransactions as well.  That is, there must be a
>>>>+        commit_sub() call between a tpc_begin() call with the
>>>>+        subtransaction flag set to true and a tpc_begin() with the
>>>>+        flag set to false.
>>>>+
>>>>+        """
>>>
>>>But there's not "subtransaction" flag for this method anymore.
>>
>>Right.  Are you worried that this is a backward compatibility issue?
> 
> 
> No no, I was just worried about the inconsistency between the signature,
> that has no 'subtransaction' arg, and the docstring that talks about one.

Ah, I missed that.  I'll fix that.

Jim

-- 
Jim Fulton           mailto:jim at zope.com       Python Powered!
CTO                  (540) 361-1714            http://www.python.org
Zope Corporation     http://www.zope.com       http://www.zope.org