[Zope-CMF] Skinnable bare except

Florent Guillaume fg at nuxeo.com
Fri Apr 22 11:19:18 EDT 2005


SkinnableObjectManager.__of__ has this code:

        try:
            w_self.setupCurrentSkin()
        except:
            # This shouldn't happen, even if the requested skin
            # does not exist.
            import sys
            from zLOG import LOG, ERROR
            LOG('CMFCore', ERROR, 'Unable to setupCurrentSkin()',
                error=sys.exc_info())

In an application we're seeing many ConflictErrors wrongly catched here.
I'm changing it to at least reraise the ConflictError directly.

Florent

-- 
Florent Guillaume, Nuxeo (Paris, France)   CTO, Director of R&D
+33 1 40 33 71 59   http://nuxeo.com   fg at nuxeo.com


More information about the Zope-CMF mailing list