[Zope-CMF] Re: Skinnable bare except

[Tres Seaver]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Florent Guillaume wrote:
> SkinnableObjectManager.__of__ has this code:
> 
>         try:
>             w_self.setupCurrentSkin()
>         except:
>             # This shouldn't happen, even if the requested skin
>             # does not exist.
>             import sys
>             from zLOG import LOG, ERROR
>             LOG('CMFCore', ERROR, 'Unable to setupCurrentSkin()',
>                 error=sys.exc_info())
> 
> In an application we're seeing many ConflictErrors wrongly catched here.
> I'm changing it to at least reraise the ConflictError directly.

+1.  Please check in wherever appropriate.  BTW, did you finish the set
of changes which missed going in to 1.4.8?  If so, somebody could roll a
1.4.9 (I think Plone 2.1 wants to release against the latest 1.4 release).


Tres.
- --
===============================================================
Tres Seaver                                tseaver at zope.com
Zope Corporation      "Zope Dealers"       http://www.zope.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFCaRtxGqWXf00rNCgRAj16AKCCcFB2Dj0aBcYrBgmSIkwH8Gt2gwCglnV+
MwgY4z4Yw5hg5+R/8+OJCQI=
=8asz
-----END PGP SIGNATURE-----