[Zope-CMF] Re: [dev] five.localsitemanager: proposal

[yuppie]

Hi!


This proposal is now implemented on CMF and five.localsitemanager trunk. 
Everything *seems* to work, but maybe I'm missing something. This might 
be a good time to review and test the changes - any feedback is welcome.


Done:
-----

There are 10 tools in CMF that are not ready for being used as 
utilities, they have to be used the old way until they are fixed:

content_type_registry
cookie_authentication
portal_actions
portal_calendar
portal_catalog
portal_skins
portal_types
portal_uidhandler
portal_url
portal_workflow


These 15 CMF tools are registered as utilities, AFAICS only the security 
machinery uses their acquisition context (except for portal_membership, 
which uses 'self.acl_users'):

Products.CMFActionIcons.interfaces.IActionIconsTool
Products.CMFCore.interfaces.ICachingPolicyManager
Products.CMFCore.interfaces.IDiscussionTool
Products.CMFCore.interfaces.IMemberDataTool
Products.CMFCore.interfaces.IMembershipTool
Products.CMFCore.interfaces.IMetadataTool
Products.CMFCore.interfaces.IPropertiesTool
Products.CMFCore.interfaces.IRegistrationTool
Products.CMFCore.interfaces.ISiteRoot
Products.CMFCore.interfaces.ISyndicationTool
Products.CMFCore.interfaces.IUndoTool
Products.CMFUid.interfaces.IUniqueIdAnnotationManagement
Products.CMFUid.interfaces.IUniqueIdGenerator
Products.GenericSetup.interfaces.ISetupTool
Products.MailHost.interfaces.IMailHost


five.localsitemanager now returns wrapped utilities without 
RequestContainers. This requires a new LookupClass.


ToDo:
-----

- real world testing

- backport to the CMF 2.1 branch

- write migration code for CMF 2.1 beta sites that replaces the 
LookupClass and removes some utility registrations

- fix the GenericSetup handler

- figure out if we can make acl_users an utility

- in the long run, modify all tools to make them work as utilities

AFAICS, KSS will no longer need the monkey patch if it sets the 
LookupClass to FiveVerifyingAdapterLookup.


Cheers,

	Yuppie