[Zope-CMF] SVN: Products.CMFCore/branches/2.2/Products/CMFCore/exportimport/content.py remove type check that seem useless

Godefroid Chapelle gotcha at bubblenet.be
Thu Jan 13 11:01:02 EST 2011


Le 13/01/11 15:52, Charlie Clark a écrit :
> Am 13.01.2011, 15:27 Uhr, schrieb Godefroid Chapelle<gotcha at bubblenet.be>:
>
>>
>> http://zope3.pov.lt/trac/changeset/119560/Products.CMFCore/branches/2.2
>
> That looks okay to me but I'm not sure if it should stay quite that way -
> a dedicated method for encoding might be preferable. `

I made a function. Feel free to move it to CMFCore.utils

see revision 119567

> But I'm not sure if
> the encoding shouldn't happen when the file is written

The file is written by ConfigParser which does not seem to support unicode.

IOW, encoding needs to happen before ConfigParser.

> - aren't there
> other places where this might be required?

AFAICS, unicode support has been done for properties.

>
> Charlie


-- 
Godefroid Chapelle (aka __gotcha) http://bubblenet.be



More information about the Zope-CMF mailing list