[ZCM] [ZC] 1781/ 8 Resolve ""create_mount_points" argument to Products.ZODBMountPoint.MountedObject.MountedObject ineffective"

[Collector: Zope Bugs, Features, and Patches ...]

Issue #1781 Update (Resolve) ""create_mount_points" argument to Products.ZODBMountPoint.MountedObject.MountedObject ineffective"
 Status Resolved, Zope/bug medium
To followup, visit:
  http://www.zope.org/Collectors/Zope/1781

==============================================================
= Resolve - Entry #8 by tseaver on May 21, 2005 11:32 pm

 Status: Accepted => Resolved

Fix checked in on the 2.7 CVS branch and the SVN trunk:

  http://cvs.zope.org/Zope/lib/python/Products/ZODBMountPoint/Attic/MountedObject.py.diff?r1=1.1.2.2&r2=1.1.2.3&hideattic=0

  http://svn.zope.org/?rev=30474&view=rev

________________________________________
= Accept - Entry #7 by tseaver on May 20, 2005 8:38 am

 Status: Pending => Accepted

 Supporters added: tseaver

OK, I'm checking this in now for the Zope 2.7 branch.  I will try
to verify against the 2.8 side, as well.
________________________________________
= Comment - Entry #6 by d.maurer on May 20, 2005 5:18 am


Uploaded:  "MountedObject2.pat"
 - http://www.zope.org/Collectors/Zope/1781/MountedObject2.pat/view
Improved patch which defines "True" as default for 'create_mount_points' as this is required for mounting "temp_folder".

No longer delete "_create_mount_points" from instances.

The test suite now passes.

New (complete) patch attached.
________________________________________
= Comment - Entry #5 by d.maurer on May 17, 2005 8:44 am

Mounting "temp_folder" requires that the effective value for '_create_mount_points' is True.

Formerly, this was ensured due to a bug in the code. After my fix, this
is no longer the case -- Zope can no longer mount "temp_folder".

To fix this, the literal default value for '_create_mount_points' (both as class attribute and as
paramter to 'manage_addMounts' must
be set to True.

Of course, the "del mo._create_mount_points" should be removed as well (as it is not sane
to forbid mount point creation and
later get them automatically created
on access).
________________________________________
= Resign - Entry #4 by tseaver on May 16, 2005 3:59 pm

 Status: Accepted => Pending

 Supporters removed: tseaver

I don't understand the interaction well enough with zope.conf to
just fix this;  with the patch in place, mount points defined
in the config file do *not* get created.
________________________________________
= Comment - Entry #3 by tseaver on May 16, 2005 3:37 pm

Except, of course, that it causes unittests to barf.
________________________________________
= Accept - Entry #2 by tseaver on May 16, 2005 3:26 pm

 Status: Pending => Accepted

 Supporters added: tseaver

It looks as though the patch will apply cleanly to the head of
the Zope-2_7-branch in CVS, as well as to the SVN trunk.
________________________________________
= Request - Entry #1 by d.maurer on May 13, 2005 9:20 am


Uploaded:  "MountedObject.pat"
 - http://www.zope.org/Collectors/Zope/1781/MountedObject.pat/view
"create_mount_points" is "or"ed (rather than "and"ed)
with "container_class" (which is apparently usually not false) and it therefore ineffective.

Patch attached
==============================================================