[Zope-dev] Is the aliasing of 'hasRole' correct?

Jean Jordaan jean@upfrontsystems.co.za
Wed, 25 Sep 2002 18:09:49 +0200


In AccessControl/User.py::

     def hasRole(self, *args, **kw):
         """hasRole is an alias for 'allowed' and has been deprecated.

         Code still using this method should convert to either 'has_role' or
         'allowed', depending on the intended behaviour.

         """
         import warnings
         warnings.warn('BasicUser.hasRole is deprecated, please use '
             'BasicUser.allowed instead; hasRole was an alias for allowed, but '
             'you may have ment to use has_role.', DeprecationWarning)
         self.allowed(*args, **kw)

Shouldn't that be::

         return self.allowed(*args, **kw)

?

-- 
Jean Jordaan
Upfront Systems                         http://www.upfrontsystems.co.za