[Zope-dev] Is the aliasing of 'hasRole' correct?

[Brian Lloyd]

> In AccessControl/User.py::
> 
>      def hasRole(self, *args, **kw):
>          """hasRole is an alias for 'allowed' and has been deprecated.
> 
>          Code still using this method should convert to either 
> 'has_role' or
>          'allowed', depending on the intended behaviour.
> 
>          """
>          import warnings
>          warnings.warn('BasicUser.hasRole is deprecated, please use '
>              'BasicUser.allowed instead; hasRole was an alias for 
> allowed, but '
>              'you may have ment to use has_role.', DeprecationWarning)
>          self.allowed(*args, **kw)
> 
> Shouldn't that be::
> 
>          return self.allowed(*args, **kw)

Yes, it should. Thanks Jean. I've checked in the fix for this.

Brian Lloyd        brian@zope.com
V.P. Engineering   540.361.1716              
Zope Corporation   http://www.zope.com