[Zope-dev] Re: On with the show....

[Tres Seaver]

On Mon, 2003-12-15 at 11:51, Casey Duncan wrote:
> On Mon, 15 Dec 2003 10:02:58 -0600
> Evan Simpson <evan at 4-am.com> wrote:
> 
> > Sidnei da Silva wrote:
> > > If you look at FSPageTemplate, its obvious that it doesn't subclass
> > > ZopePageTemplate, but the solution is not so obvious. Using:
> > > 
> > >     pt_getContext = ZopePageTemplate.pt_getContext.im_func
> > 
> > Wow, FSPageTemplate is lousy with this sort of thing, isn't it?  I'd 
> > have spelled it ZopePageTemplate.__dict__['pt_getContext'], but your 
> > code works out to the same thing.  I don't endorse this sort of 
> > cross-tree method copying, but if we're going to do it on this scale, at 
> > least we can make it tidier.  Before the Globals.InitializeClass:
> > 
> > zpd = ZopePageTemplate.__dict__
> > for m in ('func_code', '_default_bindings', 'manage_FTPget',
> >            'get_size', 'PrincipiaSearchSource', 'document_src',
> >            'pt_getContext', 'ZScriptHTML_tryParams'):
> >    setattr(FSPageTemplate, m, zpd[m])
> > 
> > > A similar error also happened with FSImage.__str__ (which is assigned
> > > Image.__str__, but FSImage just subclasses FSObject).
> > > 
> > > Any thought on those?
> > 
> > Yep -- it seems very silly to copy a one-line method like that.
> 
> Smells like a broken class hierarchy to me. I really think we need to
> consider refactoring the code so this sort of sillyness isn't necessary.

While we are at it, we need to refactor the "core" bits of ZPT
(expressions, PageTemplateFile, etc.) out of 'Products.PageTemplates'
and into a better "top-level" pacakge.  People are beginning to use PTF
for ZMI, which shouldn't break in the absence of a product.

Tres.
-- 
===============================================================
Tres Seaver                                tseaver at zope.com
Zope Corporation      "Zope Dealers"       http://www.zope.com