[Zope-dev] 2.7 management_page_charset cannot be callable anymore

[Martijn Faassen]

Brian Lloyd wrote:
> I was trying to be responsive to getting the issue resolved, since
> I'd like to make a (hopefully final) beta of 2.7 of Friday. I'll be 
> happy to check in (or have you check in) whatever fixes are needed 
> to give you the flexibility you need so long as it is b/w compatible, 
> but I won't have the time to actively figure out what those fixes 
> are this week.

Understood. I just spent some time gazing at what needs to be done
in properties.dtml (as well as manage_page_header.dtml), but frankly
the grotty DTML scares me and I already figured out a seemingly working
solution using ComputedAttribute in Formulator...

Fixing manage_page_header.dtml should be easy enough, just a one line fix:

<dtml-call "RESPONSE.setHeader('content-type','text/html;charset='+_['management_page_charset'])">

i.e. the use of _['management_page_charset']

properties.dtml however has some logic *before* manage_page_header gets
called, and doesn't seem to deal propertly with the case where
management_page_charset is manually set to UTF-8 (it doesn't go to 
UTF-8 mode in that case, I think..), and it assumes the only place
management_page_charset can be coming from is a property, which is
not true. 

Considering the amount of rewriting necessary to make this saner and the 
scariness of doing that just before a Zope 2.7 release, I'll skip it
and live with my Formulator hack solution.

Regards,

Martijn