[Zope-dev] Re: PageTemplate XML mode bugs

[yuppie]

Fred Drake wrote:
> On Tue, 05 Oct 2004 12:47:33 +0200, yuppie <y.2004_ at wcm-solutions.de> wrote:
>>#1101 looks like someone just forgot to remove a debug assert in
>>TALParser.py. The Zope3 version doesn't have that assert statement. Or
>>was there a reason to disable i18n for XML mode?
> 
> 
> That's what it looks like.  The assert isn't in the Zope 3 version of
> the code.  I suspect it can be safely removed.  I've made a note of
> this in the tracker issue.

Ok. I'll remove that line in CVS/SVN.

>>#1474 is a change backported from Zope3. It was reverted for HTML mode
>>for apparently the same reason why the XML mode is still broken. I guess
>>the motivation was to preserve CDATA, but I don't know that for sure.
> 
> 
> This report isn't clear.  Please update the issue and explain what the
> problem is; glancing at the code on the Zope 2 and Zope 3 trunks, the
> only thing that looks suspicious to me is that re-opening an HTML file
> doesn't use Python's universal newline support.
> 
> HTML is always text, so should be treated that way on input.  XML may
> contain textual content, but should always be handed to the XML parser
> as a raw byte stream to allow the proper decoding machinery a shot at
> doing the right thing.

I added a new comment to the issue. Hope that makes things clearer.
( http://collector.zope.org/Zope/1474 )

Thanks,	Yuppie