[Zope-dev] Re: [Zope 2.11] Stepping forward and going beta

[Tres Seaver]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hanno Schlichting wrote:
> Hanno Schlichting wrote:
>> Andreas Jung wrote:
>>
>> The only thing I'm going to do if no one objects is to deprecate calling
>> the ViewPageTemplateFile in Five without passing in the view. This
>> should at least allow us to merge the aq-branch without any problems for
>> Zope 2.13 if noone can think of a way around the problem.
> 
> I tried to implement this, but stumbled over too many places where code
> is not complying to interfaces and thus passing in an argument breaks code.

That indicates a lack of test coverage:  classes which claim to implment
interfaces on behalf or their instances need tests (via
'zope.interface.verify.verifyClass').

> For example the IContentProvider interface requires the render method to
> be "def render(*args, **kwargs)". Almost no viewlet is complying to this
> starting with the base viewlet manager
> zope.viewlet.manager.ViewletManagerBase which accepts no arguments.
> Passing in the view to the render method therefor doesn't work (render
> is often directly the template).

Let's just fix the viewlet classes, then.

> As a result I have abandoned this plan as well. Maybe someone can think
> of a different solution for merging or going forward with the
> aq_vs_parent branch.


Tres.
- --
===================================================================
Tres Seaver          +1 540-429-0999          tseaver at palladion.com
Palladion Software   "Excellence by Design"    http://palladion.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHdSIx+gerLs4ltQ4RAu6CAJ9ddQNCKB3gOoFYX1x4jdujjh/FtACg2b5m
c8kMc363Ys2GMOUUCJn57+Y=
=8rzL
-----END PGP SIGNATURE-----