[Zope-dev] zope.app.container won't compile

[Tres Seaver]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Philipp von Weitershausen wrote:
> Andreas Jung wrote:
>>> A trunk checkout compiles cleanly on Python 2.4:  Sidnei checked in a
>>> fix for this problem on Thursday.
>> I assume this made it into zope.app.container 3.6.1 released on October 
>> 15th:
>>
>> http://pypi.python.org/pypi/zope.app.container
>>
>> So why won't this version build with Python 2.4?
> 
> Sidnei fixed the 3.6.1 tag locally to build on Python 2.4. The fix 
> hasn't made it into a release yet. So far I didn't want to create a 
> release because I'm puzzled by the problem myself:
> 
> zope.app.container 3.5.6 builds on Python 2.4 perfectly without Sidnei's 
> fix. However, zope.app.container 3.6.x will only build on Python 2.4 
> *with* Sidnei's fix (which is available from trunk). Regarding their C 
> code, the two branches seem to be identical as far as I can tell (for 
> instance, compare 3.5.6 to 3.6.1). That's why I'm a bit puzzled. Perhaps 
> somebody else can shed light on this.

Did you look at the include' directories?

$ svn propget svn:externals $ZSVN/zope.app.container/tags/3.5.6/include
persistent      svn://svn.zope.org/repos/main/ZODB/trunk/src/persistent
zope.proxy      \
svn://svn.zope.org/repos/main/zope.proxy/trunk/src/zope/proxy

$ svn propget svn:externals $ZSVN/zope.app.container/tags/3.6.1/include
persistent     -r 71248 \
svn://svn.zope.org/repos/main/ZODB/branches/3.7/src/persistent
zope.proxy              \
svn://svn.zope.org/repos/main/zope.proxy/trunk/src/zope/proxy

Two observations:

- - No released version should have 'trunk' externals for anything.

- - The 3.5.6 version is pulling in a 'cPersistence.h' which has a
  '#include "py24compat.h"' in it.

> Of course, if everybody's just annoyed and wants to move on, I'll be 
> happy to create another 3.6.2 release with Sidnei's fix in it.

We should fix the externals for both 3.5.x and 3.6.x and re-release both.


Tres.
- --
===================================================================
Tres Seaver          +1 540-429-0999          tseaver at palladion.com
Palladion Software   "Excellence by Design"    http://palladion.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFI/Itr+gerLs4ltQ4RAoYSAKDMTDYIP7T5n7nr0psW5DaV/vgIcwCgpqSJ
p0FcaGnjtWuOOlx+zLVlqms=
=tDrK
-----END PGP SIGNATURE-----