[Zope-dev] zope.app.container won't compile

[Zvezdan Petkovic]

On Oct 20, 2008, at 9:45 AM, Tres Seaver wrote:
> Did you look at the include' directories?
>
> $ svn propget svn:externals $ZSVN/zope.app.container/tags/3.5.6/ 
> include
> persistent      svn://svn.zope.org/repos/main/ZODB/trunk/src/ 
> persistent
> zope.proxy      \
> svn://svn.zope.org/repos/main/zope.proxy/trunk/src/zope/proxy
>
> $ svn propget svn:externals $ZSVN/zope.app.container/tags/3.6.1/ 
> include
> persistent     -r 71248 \
> svn://svn.zope.org/repos/main/ZODB/branches/3.7/src/persistent
> zope.proxy              \
> svn://svn.zope.org/repos/main/zope.proxy/trunk/src/zope/proxy

FWIW, the external was changed for zope.app.container-3.5.6.

When KGS 3.4.0c5 was replaced with 3.4.0c6 somebody has removed all  
other versions of zope.app.container from KGS and stored only  
zope.app.container-3.5.6 there.  (Was that necessary?)

In KGS 3.4.0c5 there were several versions of zope.app.container with  
3.5.3 being the highest version number.

The diff between zope.app.container-3.5.3 and 3.5.6 starts like this:

===== >8 =====
Property changes on: include
___________________________________________________________________
Name: svn:externals
    - persistent     -r 71248 svn://svn.zope.org/repos/main/ZODB/ 
branches/3.7/src/persistent
zope.proxy              svn://svn.zope.org/repos/main/zope.proxy/trunk/ 
src/zope/proxy

    + persistent      svn://svn.zope.org/repos/main/ZODB/trunk/src/ 
persistent
zope.proxy      svn://svn.zope.org/repos/main/zope.proxy/trunk/src/ 
zope/proxy

===== 8< =====

So, the change was introduced then, and reverted now for 3.6.1.

> Two observations:
>
> - - No released version should have 'trunk' externals for anything.

+1

> - - The 3.5.6 version is pulling in a 'cPersistence.h' which has a
>  '#include "py24compat.h"' in it.
>
>> Of course, if everybody's just annoyed and wants to move on, I'll be
>> happy to create another 3.6.2 release with Sidnei's fix in it.
>
> We should fix the externals for both 3.5.x and 3.6.x and re-release  
> both.

+1