[Zope-dev] five.localsitemanager and unregisterUtility

[Michael Howitz]

Am 09.10.2009 um 14:41 schrieb Hanno Schlichting:

> Hi Sylvain.
>
> I'm including Michael here, who's added the mentioned feature in the
> first place.
>
> On Fri, Oct 9, 2009 at 2:22 PM, Sylvain Viollon <sylvain at infrae.com>  
> wrote:
>>   I used to use those features in Silva. It work well with 0.4, but
>>   it's broken in 1.x. (I have tests in Silva testing that).
>>
>>   This have to do with the wrapping (to remember the acquisition  
>> path)
>>   of an utility which is done inside the registry by registerUtility,
>>   which breaks the unregisterUtility.
>>
>>   unregisterUtility is checking that the component you want to
>>   unregister is the same than the one which is in the registry, for
>>   the same specification, which is not true, because the one in the
>>   registry in wrapped with a ComponentPathWrapper (in register).

It seems that I overlooked the unregisterUtility functionality when  
implementing that registerUtility stores the acquisition path.

>>   If you do grep unregisterUtility in five.localsitemanager, you have
>>   no match, but the site API defines both, so they should both
>>   works (and so be tested).
>>
>>   I volunteer myself to add test (and fix it) in the SVN, as I need
>>   that fix.
>>
>>   Does anyone have an objection with that ?
>
> No objection, please go ahead.

+ 1

>>   Does any official maintainer will do a release (1.1.1, as it will  
>> be
>>   a bug fix) afterwards ?
>
> Sure, ping me once you are done and I'll cut a new release. Michael,
> do you want to test anything, before I do a new release?

For me it's enough that the tests inside five.localsitemanager succeed.


Yours sincerely,
-- 
Michael Howitz · mh at gocept.com · software developer
gocept gmbh & co. kg · forsterstraße 29 · 06112 halle (saale) · germany
http://gocept.com · tel +49 345 1229889 8 · fax +49 345 1229889 1
Zope and Plone consulting and development