[Zope-PAS] mutable property sheets

[Jens Vagelpohl]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


On 16 Apr 2006, at 17:46, Wichert Akkerman wrote:

> Previously Jens Vagelpohl wrote:
>> - - IMutablePropertiesPlugin.getPropertiesForUser deviates from the
>> original contract in IPropertiesPlugin.getPropertiesForUser and
>> returns a property sheet object instead of a mapping. IMHO it should
>> return a mapping.
>
> It has to return an object so it can persist property changes.

Ah, right, that's how something is retrieved that will actuate the  
magic. Ugh.


>> - - setting properties on a user will magically turn around and  
>> persist
>> the change. This would be the first user folder I have seen where
>> this happens. Personally, I'm a bit uncomfortable with this magic.
>
> setProperty on GRUFUser will persist the change as well.

I hate to say it, but GRUF isn't an example for anything right or  
good when it comes to user folders. And that opinion goes right up to  
the top in Plone circles.

So my own opinion is that I don't like the persistence magic for  
setting properties. IMHO the methods on the properties plugins should  
be called explicitly instead of automatically whenever anyone touches  
one of these mutable property sheets.

This is just one opinion, I hope others will chime in as well.

jens

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (Darwin)

iD8DBQFEQm5bRAx5nvEhZLIRAnbYAJ47QaUil6WWiQ6MM9syC1d65OwFegCgpImW
CGbDwcwX/XSFnYTXRJ5NjE8=
=KRrT
-----END PGP SIGNATURE-----