[Zope] problem with commits in SQLAlchemyDA

[Tres Seaver]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Brad Allen wrote:
> Tres Seaver said:
>> Thanks for taking this initiative, Brad!
> 
> Thanks for the encouragement.
> 
> Kader got started on this and he came up with a couple of questions:
> 
> * The tests for SQLALchemy DA make use of ZopeTestCase. Is that
> deprecated? I found a discussion of Zope test runners in zope-dev,
> thread titled "circular dependency hell", which left me confused about
> where Zope testing is going.

Functional testing for Zope2 products likely still uses the
Testing.ZopeTestCase fixtures.  That discussion was largely about how to
move forward the lower-level unit and integration tests for the ZTK
packages (not specific to Zope2 at all), particularly to ease porthing
the ZTK to Python 3.

> * The tests were written for SQLALchemy 0.4, which had a
> "session.save" method. SQLAlchemy 0.5 and 0.6 use "session.add". Do we
> need to maintain support for SQLAlchemy 0.4? I am tempted to make this
> new release support only 0.5 and 0.6, and see if anyone squawks.
> Hopefully most everyone has migrated to at least 0.5. (We can support
> both with conditional sqlalchemy.__version__ checks, but that can get
> ugly).

I'm not a user, so I won't express a preference.  If you do drop support
for the earlier version of SA, then you need to probably bump the major
versino number of the product, as well as highlighting that change
prominently in the CHANGES.txt.



Tres.
- --
===================================================================
Tres Seaver          +1 540-429-0999          tseaver at palladion.com
Palladion Software   "Excellence by Design"    http://palladion.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkvXIQgACgkQ+gerLs4ltQ4kHwCgpc/F00KfGnxJU0AoA3kwIOCj
C3MAn1vMxKtgdY1Ja89nvCiQ26XRFTJT
=eO80
-----END PGP SIGNATURE-----