April 2006 - Zope-Dev

Re: [Checkins] SVN: Zope/trunk/ Fixed collector 2057: Testing.makequest broke getPhysicalPath()
by Stefan H. Holek 07 Apr '06

07 Apr '06

For the record: I am still opposed to this change. It basically endows the request (as in self.REQUEST) with a getPhysicalPath method, and I have no idea what kind of side-effects this may have. AFAICS your test suite is the only suite around that wants to request- wrap non-root objects. There's nothing wrong with using your own makerequest for your own test suite, if this is what you want. But I don't think your use-case warrants changing Zope. Stefan On 5. Apr 2006, at 22:51, Paul Winkler wrote: > Log message for revision 66581: > Fixed collector 2057: Testing.makequest broke getPhysicalPath() > when used on anything other than an app object. > Also added an 'environ' argument if you want to use something > other than os.environ, and added a couple trivial tweaks from > ZopeTestCase.makereqeust. > Added unit tests for this stuff. > > > > Changed: > U Zope/trunk/doc/CHANGES.txt > U Zope/trunk/lib/python/Testing/makerequest.py > A Zope/trunk/lib/python/Testing/tests/ > A Zope/trunk/lib/python/Testing/tests/__init__.py > A Zope/trunk/lib/python/Testing/tests/test_makerequest.py > > -=- > Modified: Zope/trunk/doc/CHANGES.txt > =================================================================== > --- Zope/trunk/doc/CHANGES.txt 2006-04-05 20:04:59 UTC (rev 66580) > +++ Zope/trunk/doc/CHANGES.txt 2006-04-05 20:51:21 UTC (rev 66581) > @@ -46,6 +46,9 @@ > > Features added > > + - Testing.makerequest: Added an 'environ' argument so > + clients can use mappings other than os.environ. > + > - Updated to Docutils 0.4.0 > > - reStructuredText: The default value for the 'stylesheet' > @@ -202,6 +205,10 @@ > > Bugs Fixed > > + - Collector #2057: Allow Testing.makerequest to work with > + any acquisition-supporting root object, not just Zope2.app. > + Formerly, if you did that, getPhysicalPath() was broken. > + > - Collector #2051: Applied patch by Yoshinori Okuji to fix some > XML export/import problems, including tests for that feature. > > > Modified: Zope/trunk/lib/python/Testing/makerequest.py > =================================================================== > --- Zope/trunk/lib/python/Testing/makerequest.py 2006-04-05 > 20:04:59 UTC (rev 66580) > +++ Zope/trunk/lib/python/Testing/makerequest.py 2006-04-05 > 20:51:21 UTC (rev 66581) > @@ -19,27 +19,50 @@ > import makerequest > app = makerequest.makerequest(Zope2.app()) > > +You can optionally pass stdout to be used by the response, > +and an environ mapping to be used in the request. > +Defaults are sys.stdout and os.environ. > + > +If you don't want to start a zope app in your test, you can wrap > other > +objects, but they must support acquisition and you should only wrap > +your root object. > + > + > $Id$ > > """ > > import os > -from os import environ > from sys import stdin, stdout > from ZPublisher.HTTPRequest import HTTPRequest > from ZPublisher.HTTPResponse import HTTPResponse > from ZPublisher.BaseRequest import RequestContainer > > -def makerequest(app, stdout=stdout): > +def makerequest(app, stdout=stdout, environ=None): > resp = HTTPResponse(stdout=stdout) > - environ['SERVER_NAME']='foo' > - environ['SERVER_PORT']='80' > - environ['REQUEST_METHOD'] = 'GET' > + if environ is None: > + environ = os.environ > + environ.setdefault('SERVER_NAME', 'foo') > + environ.setdefault('SERVER_PORT', '80') > + environ.setdefault('REQUEST_METHOD', 'GET') > req = HTTPRequest(stdin, environ, resp) > - > + req._steps = ['noobject'] # Fake a published object. > + req['ACTUAL_URL'] = req.get('URL') # Zope 2.7.4 > + > # set Zope3-style default skin so that the request is usable for > - # Zope3-style view look-ups > + # Zope3-style view look-ups. > from zope.app.publication.browser import setDefaultSkin > setDefaultSkin(req) > > - return app.__of__(RequestContainer(REQUEST = req)) > + requestcontainer = RequestContainer(REQUEST = req) > + # Workaround for collector 2057: ensure that we don't break > + # getPhysicalPath if app has that method. > + # We could instead fix Traversable.getPhysicalPath() to check for > + # existence of p.getPhysicalPath before calling it; but it's such > + # a commonly called method that I don't want to impact > performance > + # for something that AFAICT only affects makerequest() in > + # practice. > + if getattr(app, 'getPhysicalPath', None) is not None: > + requestcontainer.getPhysicalPath = lambda: () > + > + return app.__of__(requestcontainer) > > Added: Zope/trunk/lib/python/Testing/tests/__init__.py > =================================================================== > --- Zope/trunk/lib/python/Testing/tests/__init__.py 2006-04-05 > 20:04:59 UTC (rev 66580) > +++ Zope/trunk/lib/python/Testing/tests/__init__.py 2006-04-05 > 20:51:21 UTC (rev 66581) > @@ -0,0 +1 @@ > +# > > > Property changes on: Zope/trunk/lib/python/Testing/tests/__init__.py > ___________________________________________________________________ > Name: svn:keywords > + "Author Date Revision" > > Added: Zope/trunk/lib/python/Testing/tests/test_makerequest.py > =================================================================== > --- Zope/trunk/lib/python/Testing/tests/test_makerequest.py > 2006-04-05 20:04:59 UTC (rev 66580) > +++ Zope/trunk/lib/python/Testing/tests/test_makerequest.py > 2006-04-05 20:51:21 UTC (rev 66581) > @@ -0,0 +1,65 @@ > +##################################################################### > ######### > +# > +# Copyright (c) 2006 Zope Corporation and Contributors. All Rights > Reserved. > +# > +# This software is subject to the provisions of the Zope Public > License, > +# Version 2.1 (ZPL). A copy of the ZPL should accompany this > distribution. > +# THIS SOFTWARE IS PROVIDED "AS IS" AND ANY AND ALL EXPRESS OR > IMPLIED > +# WARRANTIES ARE DISCLAIMED, INCLUDING, BUT NOT LIMITED TO, THE > IMPLIED > +# WARRANTIES OF TITLE, MERCHANTABILITY, AGAINST INFRINGEMENT, AND > FITNESS > +# FOR A PARTICULAR PURPOSE. > +# > +##################################################################### > ######### > +"""Unit tests of makequest. > + > +$Id$ > +""" > + > +import unittest > + > +from Acquisition import Implicit > +from Testing.makerequest import makerequest > +from OFS.SimpleItem import SimpleItem > + > +class MakerequestTests(unittest.TestCase): > + > + def test_makerequest(self): > + # The argument must support acquisition. > + self.assertRaises(AttributeError, makerequest, object()) > + # After the call, it will have a REQUEST attribute. > + item = Implicit() > + self.failIf(hasattr(item, 'REQUEST')) > + item = makerequest(item) > + self.failUnless(hasattr(item, 'REQUEST')) > + > + def test_dont_break_getPhysicalPath(self): > + # see http://www.zope.org/Collectors/Zope/2057 > + item = SimpleItem() > + self.assertEqual(item.getPhysicalPath(), ('',)) > + self.assertEqual(item.getPhysicalPath(), > + makerequest(item).getPhysicalPath()) > + > + def test_stdout(self): > + # You can pass a stdout arg and it's used by the response. > + import cStringIO > + out = cStringIO.StringIO() > + item = makerequest(SimpleItem(), stdout=out) > + item.REQUEST.RESPONSE.write('aaa') > + out.seek(0) > + written = out.read() > + self.failUnless(written.startswith('Status: 200 OK\n')) > + self.failUnless(written.endswith('\naaa')) > + > + def test_environ(self): > + # You can pass an environ argument to use in the request. > + environ = {'foofoo': 'barbar'} > + item = makerequest(SimpleItem(), environ=environ) > + self.assertEqual(item.REQUEST.environ['foofoo'], 'barbar') > + > +def test_suite(): > + suite = unittest.TestSuite() > + suite.addTest(unittest.makeSuite(MakerequestTests)) > + return suite > + > +if __name__=='__main__': > + unittest.TextTestRunner().run(test_suite()) > > > Property changes on: Zope/trunk/lib/python/Testing/tests/ > test_makerequest.py > ___________________________________________________________________ > Name: svn:keywords > + "Author Date Revision" > > _______________________________________________ > Checkins mailing list > Checkins(a)zope.org > http://mail.zope.org/mailman/listinfo/checkins -- Anything that happens, happens. --Douglas Adams

4 5

Zope Test Summaries 2006-04-05
by Stefan H. Holek 07 Apr '06

07 Apr '06

[We seem to have lost Steve Alexander's test summarizer. I will contact him in a separate mail.] The switch to Python 2.3.4 caused tests for Zope 2.7 and 2.8 to experience a funny problem with the logging module. Anybody want to take a guess what's up here? I know these are not a truly "supported" configurations, but still. http://mail.zope.org/pipermail/zope-tests/2006-April/004645.html http://mail.zope.org/pipermail/zope-tests/2006-April/004647.html The VHM tests in Zope 2.9 and trunk broke last night: http://mail.zope.org/pipermail/zope-tests/2006-April/004648.html http://mail.zope.org/pipermail/zope-tests/2006-April/004649.html Stefan -- Anything that happens, happens. --Douglas Adams

4 7

What from zope.app are you using
by Philipp von Weitershausen 07 Apr '06

07 Apr '06

Hi there, we don't really want to ship all of zope.app with Zope 2. zope.app is supposed to be the Zope 3 application server. It shouldn't be included in Zope 2, especially since it requires twisted and such. We're therefore moving everything that isn't part of the core Zope 3 application server out of zope.app so that we won't have to include zope.app in future Zope 2 versions. Perhaps we can deprecate zope.app in Zope 2.10. I've compiled a list of zope.app subpackages that are directly used by Zope2/Five in a proposal: http://dev.zope.org/Zope3/MakeZopeAppSmaller. I am currently in the process of implementing this proposal on the jim-adapter branch of Zope 3. I would like to know what other zope.app packages your 3rd party software is using. If thereare any other used than the ones mentioned in the proposal, we'll have to move them out of zope.app. I'd like to ask for your help on that, otherwise future Zope 2 versions might not anymore include the package you're using. Philipp

9 31

Re: [Zope-dev] What from zope.app are you using
by Martin Aspeli 07 Apr '06

07 Apr '06

On Thu, 06 Apr 2006 15:42:34 +0100, whit <whit(a)burningman.com> wrote: > to echo Martijn, I've learned much more about zope3 thumbing through the > z3 bundled with Zope 2 than I have looking at actual zope3 source, > because I don't have a job that pays me to do pure zope3. > > I would argue sending the whole enchilada is good social programming. > one less download before someone explores the codebase and a lower > barrier to experimentation if someone gets the itch to integrate a z3 > feature into zope2. +10 zope.app smaller, better modularised - good zope.app gone for the sake of purity - bad (I suspect Philipp wasn't arging for this, though, only to use the Zope 2 comparison as a guide) Martin -- (muted)

2 1

Very minor bugfix suggestion. Strip role names
by Lennart Regebro 06 Apr '06

06 Apr '06

When adding new rols through the ZMI it is easy to accidentaly let trailing or leading spaces stay in the role name, especially if you cut and paste. Debugging that is very annoying because that leading and trailing space is not visible anywhere. So, I suggest to just add a .strip() like so (This is in Roles.py): def manage_defined_roles(self, submit=None, REQUEST=None): """Called by management screen. """ if submit=='Add Role': role=reqattr(REQUEST, 'role') return self._addRole(role.strip(), REQUEST) -- Lennart Regebro, Nuxeo http://www.nuxeo.com/ CPS Content Management http://www.cps-project.org/

2 1

Re: [Zope-dev] What from zope.app are you using
by Philipp von Weitershausen 06 Apr '06

06 Apr '06

Brian Sutherland wrote: > On Wed, Apr 05, 2006 at 11:18:46PM +0200, Philipp von Weitershausen wrote: >> Brian Sutherland wrote: >>> On Wed, Apr 05, 2006 at 05:29:41PM +0200, Philipp von Weitershausen wrote: >>>> I would like to know what other zope.app packages your 3rd party >>>> software is using. >>> Er, FiveSQLOS is using quite a lot actually: >>> >>> https://codespeak.net/svn/z3/sqlos/trunk/Zope2/FiveSQLOS/dependencies-meta.… >>> https://codespeak.net/svn/z3/sqlos/trunk/Zope2/FiveSQLOS/dependencies.zcml >> Why are you loading zope.app.component/meta.zcml and >> zope.app.security/meta.zcml? Five should provide all the necessary >> directive registrations > > I havn't touched that code since the Zope2.8 days. I'll believe you for > now and try testing it when the dust has settled. Ok. By the way, that "should" in "Five should provide..." also means that if Five doesn't provide the necessary directive registrations yet (which might very well be), then we need to make it. >> As for zope.app.rdb, I guess we'll have to move it down to zope.rdb. > > I can probably take care of that in the next days. Great. Note that I'm working on the jim-adapter branch. I suggest you do your modifications there as well. Philipp

2 2

makerequest issues
by Paul Winkler 05 Apr '06

05 Apr '06

Several things: 1) there is a "makerequest" function in both Testing/makerequest.py and Testing/ZopeTestCase/utils.py. They are subtly different. Is there a deliberate reason for this? I notice that the one in utils.py lacks the recent fix for zope 3 views, and the one in makerequest.py lacks an ACTUAL_URL. 2) re. the bug which I just posted at http://www.zope.org/Collectors/Zope/2057 the issue is that if you have something that inherits Traversable, and wrap it with makerequest(), its getPhysicalPath() method is broken, because getPhysicalPath() tries to call getPhysicalPath() on all non-None aq_parents, and an HTTPRequest isn't Traversable. There are two possible fixes to that bug: I could hack around it in makerequest() by adding a fake getPhysicalPath(). I've uploaded a patch to the collector that does this. - or - I could change the conditional in Traversable.getPhysicalPath to look like so: def getPhysicalPath(self): ... p = aq_parent(aq_inner(self)) if p is not None and getattr(p, 'getPhysicalPath', None) is not None: path = p.getPhysicalPath() + path ... I was reluctant to do the latter because of two worries: a) I figured it's called all over the place and even slightly adding to its workload might negatively impact performance; the attached timeit script shows about a 15% slowdown in the method, however, I've not been able to measure any difference when hitting a default plone front page with ab. b) I don't know if there is code that relies on the current behavior of getPhysicalPath(), i.e. raise an AttributeError if p is something other than None but still lacks getPhysicalPath. I can't imagine a use case, but who knows... Opinions? -- Paul Winkler http://www.slinkp.com

2 11

Re: [Zope-dev] What from zope.app are you using
by Philipp von Weitershausen 05 Apr '06

05 Apr '06

Brian Sutherland wrote: > On Wed, Apr 05, 2006 at 05:29:41PM +0200, Philipp von Weitershausen wrote: >> I would like to know what other zope.app packages your 3rd party >> software is using. > > Er, FiveSQLOS is using quite a lot actually: > > https://codespeak.net/svn/z3/sqlos/trunk/Zope2/FiveSQLOS/dependencies-meta.… > https://codespeak.net/svn/z3/sqlos/trunk/Zope2/FiveSQLOS/dependencies.zcml Why are you loading zope.app.component/meta.zcml and zope.app.security/meta.zcml? Five should provide all the necessary directive registrations As for zope.app.rdb, I guess we'll have to move it down to zope.rdb. > zope.app.container Will move to zope.container. > zope.app.location Moved to zope.location. > zope.app.exception What from zope.app.exception are you using? If it's just UserError, than that's ok. It's moved to zope.exceptions now. Philipp

1 0

Question about RTFExport
by BKJ＠telefonica.net 05 Apr '06

05 Apr '06

Hello, I'm using the RTFExport product. It woks well, but I have a question. I'm exporting the fields of my archetype, and the result file shows every field. This result file hasn't any format. I would like to create a RTF file with the same format that I see in the Edit mode or the View mode (in Plone). Is it possible? Thanks. TERRA -->

2 1

Hunting down objects without classes...
by Chris Withers 05 Apr '06

05 Apr '06

Hi All, I'm currently plagued by the following annoying: ZODB Could not import class 'BTree' from module 'BTree' What's the recommended way of tracking these down? Is there anything we can do to make the logged message give more info about where the object is? I eventually stab-in-the-dark'ed it on this one and found the offending object in the root dictionary of a storage I was mounting some stuff from... cheers, Chris -- Simplistix - Content Management, Zope & Python Consulting - http://www.simplistix.co.uk

2 1