August 2009 - Zope-Dev

MailHost Improvements
by Alec Mitchell 15 Aug '09

15 Aug '09

Hello, I've been working on making Plone use the standard Zope MailHost in place of the custom Products.SecureMailHost we've been using since Plone 2.1 (See: http://dev.plone.org/plone/ticket/8814) During this process I've run into a couple bugs in the MailHost implementation and I believe it is missing some essential functionality. The most significant issue is that if you call send() with a messageText containing just the message body, and that body has a ':' in it (e.g. a url) the body will be treated as a header and you'll send a nonsense message. The current implementation of send() also puts a fairly large burden on developers who want to generate simple, correctly encoded messages. Finally, send() relies heavily on the long deprecated 'rfc822' and 'mimetools' modules which have been removed from Python 3.0. I've attached a patch that updates MailHost to use the 'email' module for parsing and generating messages. In addition to fixing the issues that I ran across, and maintaining compatibility, it provides a number of new features: * send and sendTemplate accept an optional charset argument. Using this will set the content-type charset, as well as trigger appropriate encoding if needed. * send and sendTemplate accept an optional msg_type argument which will set the content type header for the message. * The messageText, mfrom, mto, and subject arguments may now be unicode or encoded non-ascii strings, provided a charset is given. Any unicode input will be automatically encoded to the provided charset (or the default charset). Headers will be further encoded in compliance with rfc2822. The message body will be further encoded using a transfer encoding determined by the email.Charset registry (e.g. 7bit for us-ascii, quoted-printable for utf-8 and iso8859, base64 for most other encodings). * The messageText argument now accepts email.Message.Message objects directly. I'm attaching a patch that includes these changes as well as tests for all new functionality. I hope to integrate these changes into Zope 2.12 before final release, but would like to hear the opinions of Zope developers before committing. Though these are fairly significant changes, I believe they provide very useful functionality as well as at least one critical fix, while maintaining 100% compatibility. Thanks, Alec

4 7

Zope Tests: 8 OK
by Zope Tests Summarizer 15 Aug '09

15 Aug '09

Summary of messages to the zope-tests list. Period Fri Aug 14 12:00:00 2009 UTC to Sat Aug 15 12:00:00 2009 UTC. There were 8 messages: 8 from Zope Tests. Tests passed OK --------------- Subject: OK : Zope-2.10 Python-2.4.6 : Linux From: Zope Tests Date: Fri Aug 14 20:46:35 EDT 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-August/012296.html Subject: OK : Zope-2.11 Python-2.4.6 : Linux From: Zope Tests Date: Fri Aug 14 20:48:35 EDT 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-August/012297.html Subject: OK : Zope-2.12 Python-2.4.6 : Linux From: Zope Tests Date: Fri Aug 14 20:50:35 EDT 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-August/012298.html Subject: OK : Zope-2.12 Python-2.6.2 : Linux From: Zope Tests Date: Fri Aug 14 20:52:40 EDT 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-August/012299.html Subject: OK : Zope-2.12-alltests Python-2.4.6 : Linux From: Zope Tests Date: Fri Aug 14 20:54:40 EDT 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-August/012300.html Subject: OK : Zope-2.12-alltests Python-2.6.2 : Linux From: Zope Tests Date: Fri Aug 14 20:56:40 EDT 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-August/012301.html Subject: OK : Zope-trunk Python-2.6.2 : Linux From: Zope Tests Date: Fri Aug 14 20:58:40 EDT 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-August/012302.html Subject: OK : Zope-trunk-alltests Python-2.6.2 : Linux From: Zope Tests Date: Fri Aug 14 21:00:40 EDT 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-August/012303.html

1 0

Working KGS tool! (was Re: IRC discussion about testing)
by Jim Fulton 14 Aug '09

14 Aug '09

On Thu, Aug 13, 2009 at 2:26 AM, Wolfgang Schnerring<ws(a)gocept.com> wrote: > * Jim Fulton <jim(a)zope.com> [2009-08-12 20:56]: ... >> Here's an alternative: >> >> [versions] >> zope.foo = 1.2.3 >> zope.bar = 1.2.3 >> zope.app.baz = 1.2.3 >> grok.bar = 1.1.0 >> thirdparty.dependency = 4.4 >> >> [ztk] >> projects = zope.foo zope.bar zope.app.baz >> also-tested = grok.bar > > Yup, that looks much better. As far as I'm concerned, let's use this. > (I'll leave it to Martijn to explain whether/which/why additional > information should be stored in the KGS in computer-readable form.) > > I've just updated z3c.recipe.compattest to support exactly this: ... > Would you give it a try? Yup. Works great. I've updated: svn://svn.zope.org/repos/main/zopetoolkit/branches/jim-kgs/kgs to use it. I created ztk.cfg that looks like: [ztk] libraries = ... under-review = ... projects = ${ztk:libraries} ${ztk:under-review} [buildout] versions = versions allow-picked-versions = false [versions] ... and a buildout.cfg: [buildout] parts = test-ztk extends = ztk.cfg [test-ztk] recipe = z3c.recipe.compattest include = ${ztk:projects} This gives me the test files I expect that use the specified versions. One minor quibble is that the recipe uses the part name as a test file prefix for the individual tests (e.g. test-ztk-zope.proxy). But the combined test runner has "test-" in front of the part name, so I get "test-test-ztk". I'd like to use the part name for the combined test name, "test-ztk". Thanks. Thanks too to Fabio for helping to move this forward! So, I think we now have a tool that will let us take the next steps. Can we all agree on this? Jim -- Jim Fulton

3 2

zope.testing 3.8.0 problems?
by Chris Withers 14 Aug '09

14 Aug '09

Hi All, just updated one of my packages buildouts and tried to run the tests, I got: $ bin/test Test-module import failures: Module: mortar.tests.test_docs ValueError: Module-relative files may not have absolute paths Running zope.testing.testrunner.layer.UnitTests tests: Set up zope.testing.testrunner.layer.UnitTests in 0.000 seconds. Ran 42 tests with 0 failures and 0 errors in 0.023 seconds. To try and figure out where this rather unhelpful message (which doesn't occur when the same tests are run with the same versions of all eggs on Windows) was coming from, I tried: $ bin/test -D Traceback (most recent call last): File "bin/test", line 28, in <module> <snip> "/home/chris/buildout-eggs/zope.testing-3.8.0-py2.6.egg/zope/testing/testrunner/find.py", line 95, in __init__ raise TypeError('If post_mortem is specified, ' TypeError: If post_mortem is specified, full exc_info must be passed! No idea what this means either... anyone? Chris -- Simplistix - Content Management, Batch Processing & Python Consulting - http://www.simplistix.co.uk

2 4

Zope Tests: 8 OK
by Zope Tests Summarizer 14 Aug '09

14 Aug '09

Summary of messages to the zope-tests list. Period Thu Aug 13 12:00:00 2009 UTC to Fri Aug 14 12:00:00 2009 UTC. There were 8 messages: 8 from Zope Tests. Tests passed OK --------------- Subject: OK : Zope-2.10 Python-2.4.6 : Linux From: Zope Tests Date: Thu Aug 13 20:43:54 EDT 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-August/012288.html Subject: OK : Zope-2.11 Python-2.4.6 : Linux From: Zope Tests Date: Thu Aug 13 20:45:54 EDT 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-August/012289.html Subject: OK : Zope-2.12 Python-2.4.6 : Linux From: Zope Tests Date: Thu Aug 13 20:47:54 EDT 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-August/012290.html Subject: OK : Zope-2.12 Python-2.6.2 : Linux From: Zope Tests Date: Thu Aug 13 20:49:54 EDT 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-August/012291.html Subject: OK : Zope-2.12-alltests Python-2.4.6 : Linux From: Zope Tests Date: Thu Aug 13 20:51:54 EDT 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-August/012292.html Subject: OK : Zope-2.12-alltests Python-2.6.2 : Linux From: Zope Tests Date: Thu Aug 13 20:53:54 EDT 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-August/012293.html Subject: OK : Zope-trunk Python-2.6.2 : Linux From: Zope Tests Date: Thu Aug 13 20:55:54 EDT 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-August/012294.html Subject: OK : Zope-trunk-alltests Python-2.6.2 : Linux From: Zope Tests Date: Thu Aug 13 20:57:54 EDT 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-August/012295.html

1 0

plone.z3cform: ExtensibleForm should not change groups class attribute
by Gerhard Weis 14 Aug '09

14 Aug '09

Hi, Sorry if this is the wrong list, but as plone.z3cform is in the zope-svn. I thought it may be Ok. There is a small problem in plone.z3cform. The class plone.z3cform.fieldsets.extensible.ExtensibleForm has a class attribute groups, which is changed by the provided API methods. I don't think this is intentional, becuase it makes it hard to recreate additional instances of ExtensibleForm. The current behaviour works for forms which use already groups, but for forms, where the EtensibleForm creates new groups on the fly, it does not work. The attached patch fixes this. It also includes a small addition to the Readme, which failes without the patch applied, and runes clean with the patch applied. cheers, Gerhard

2 1

KGS trunk without failures
by Stephan Richter 13 Aug '09

13 Aug '09

Hi everyone, last week I worked on getting the KGS trunk located in zope.release to pass without failures. (Python 2.5 on Linux, i686) It is in the best interest of everyone to keep the trunk in a passing condition. So please try hard to do that. I am certainly very tired of spending many hours fixing those sorts of problems. Failures were due to a wide variety of issues: - Missing imports! - Unreleased fixes. - Insufficient dependency lists. - Incompatible API changes. - Bug fixes in other packages. For the same reasons, there is a whole lot of packages I cannot add to the KGS without making further releases. If someone could setup a buildbot to run all the tests nightly, that would be great. Regards, Stephan -- Entrepreneur and Software Geek Google me. "Zope Stephan Richter"

7 18

Zope Tests: 7 OK
by Zope Tests Summarizer 13 Aug '09

13 Aug '09

Summary of messages to the zope-tests list. Period Wed Aug 12 12:00:00 2009 UTC to Thu Aug 13 12:00:00 2009 UTC. There were 7 messages: 7 from Zope Tests. Tests passed OK --------------- Subject: OK : Zope-2.10 Python-2.4.6 : Linux From: Zope Tests Date: Wed Aug 12 20:53:22 EDT 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-August/012281.html Subject: OK : Zope-2.12 Python-2.4.6 : Linux From: Zope Tests Date: Wed Aug 12 20:57:22 EDT 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-August/012282.html Subject: OK : Zope-2.12 Python-2.6.2 : Linux From: Zope Tests Date: Wed Aug 12 20:59:22 EDT 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-August/012283.html Subject: OK : Zope-2.12-alltests Python-2.4.6 : Linux From: Zope Tests Date: Wed Aug 12 21:01:22 EDT 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-August/012284.html Subject: OK : Zope-2.12-alltests Python-2.6.2 : Linux From: Zope Tests Date: Wed Aug 12 21:03:22 EDT 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-August/012285.html Subject: OK : Zope-trunk Python-2.6.2 : Linux From: Zope Tests Date: Wed Aug 12 21:05:22 EDT 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-August/012286.html Subject: OK : Zope-trunk-alltests Python-2.6.2 : Linux From: Zope Tests Date: Wed Aug 12 21:07:22 EDT 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-August/012287.html

1 0

[Zope 2.11+] '-C' key in REQUEST.form
by Andreas Jung 13 Aug '09

13 Aug '09

I just came across the fact that an empty REQUEST contains a key-value pair '-C : '' in REQUEST.form. Does anyone know where this is coming from? Andreas -- ZOPYX Ltd. & Co KG \ ZOPYX & Friends Charlottenstr. 37/1 \ The experts for your Python, Zope and D-72070 Tübingen \ Plone projects www.zopyx.com, info(a)zopyx.com \ www.zopyx.de/friends, friends(a)zopyx.de ------------------------------------------------------------------------ E-Publishing, Python, Zope & Plone development, Consulting

2 1

For the record - a minimum changes to zope.proxy to support zope.deferredimport under google app engine
by Tim Hoffman 13 Aug '09

13 Aug '09

Hi Folks This is a quick and dirty change and to be honest the main reason I am posting it here is so there is a searchable record for anyone else who wants to use zope.deferredimport under google app engine. (With some content models zope.deferredimport is a great way of dealing with cyclic dependancies and possibly improving startup times - see bottom of this email.) Below is a minimal set of changes to zope.proxy.__init__ that is required so that zope.deferredimport can be used. It does mean you need peak.utils to implement a basic proxy. try: from zope.proxy._zope_proxy_proxy import * from zope.proxy._zope_proxy_proxy import _CAPI except NotImplementedError: from peak.util.proxies import ObjectProxy class ProxyBase(ObjectProxy): pass def getProxiedObject(obj): if hasattr(obj,'__subject__'): return obj.__subject__ else: return obj def removeAllProxies(obj): return getProxiedObject(obj) def sameProxiedObjects(obj1,obj2): if getProxiedObject(obj1) == getProxiedObject(obj2): return True else: return False There are a couple of other zope.proxy functions from the 'c' api that I haven't looked at yet as they aren't used by zope.deferredimport. Suggestions on improving it and/or followups on the other functions would also be welcome. I have also found that deferred import can help with app engine startup times as it means you can import a module you depend on but not really import the code until it gets touched which can allow you to stagger you startup costs. (For instance edit functionality of a site could be deferred until someone actually edits something). Hope this helps someone Regards Tim Hoffman

1 1