- Zope-Dev - Zope lists

Re: [Zope-dev] zope.publisher 3.5 branch has code/behavior not a part of subsequent releases
by Gary Poster 25 Aug '09

25 Aug '09

Hm. I sent this from the wrong account, so it didn't make it to the zope-dev list. I'm also adding an additional bit of war story at the end. On Aug 24, 2009, at 11:16 AM, Gary Poster wrote: > Hi Tres > > I made a 3.5.8 release of the zope.publisher 3.5 branch for a reason > unimportant to this email (I backported a change to trunk that was > discussed on the mailing list). It looks like you made a 3.5.7 with > the following change (omitting tests and the like). > > 98932 tseaver # Python 2.6 notices QS-on-POST, > which breaks BBB for us. > 98932 tseaver # Suppress that. > 98932 tseaver if 'QUERY_STRING' in self._environ: > 98932 tseaver env = self._environ > 98932 tseaver env['X-POST-QUERY_STRING'] = > env.pop('QUERY_STRING') > > I can handle adjusting to this change, if it is appropriate, but my > concern is that it is not in trunk or any subsequent major release > (3.6, 3.7, 3.8) of zope.publisher. Therefore, if I change my code > to use my updated 3.5 release, which I had hoped would be a > conservative update, I have to change in a currently forward- > incompatible way. > > What's the story here? Is 3.5.7 a brownbag that needs to have its > changes aborted in a subsequent release in that branch? Or are > those legitimate changes that need to be forward ported? > > FWIW, we (Launchpad) also care about this case of a POST with other > pertinent, separate data in the query string, and the behavior you > implement here would be fine if it is necessary for Py 2.6 as your > comment describes. Also FWIW, this change breaks many of our forms that were explicitly constructing form actions that included the current query string. I'm not sure how that could be avoided, although the fix might have been simpler if there were always an X-ORIGINAL-QUERY_STRING or something else. If I were not already behind, I would investigate to understand the Python 2.6 problem better and see what other frameworks are doing here. I understand from conversations with other engineers that at least some Django developers are accustomed to always having access to the query string on the request object, whether the method were get or post or whatever else. > > Gary

3 5

Product configuration in zope.app.wsgi
by Uli Fouquet 25 Aug '09

25 Aug '09

Hi there, As it turned out product configurations are not set with zope.app.wsgi (contrary, for instance, to zope.app.server). If in your zope.conf you define:: <product-config prod1> key1 = val1 </product-config> these setting won't be accessible on startup using zope.app.wsgi and zope.app.appsetup.product.getProductConfiguration(). Apparently only the appropriate setProductConfigurations() call had to be included in zope.app.wsgi to support it. Is there a special reason why that was not included in zope.app.wsgi? If not, I'd be glad to fix this. Or did I miss something important here? Best regards, -- Uli

2 1

Zope Tests: 8 OK
by Zope Tests Summarizer 24 Aug '09

24 Aug '09

Summary of messages to the zope-tests list. Period Sun Aug 23 12:00:00 2009 UTC to Mon Aug 24 12:00:00 2009 UTC. There were 8 messages: 8 from Zope Tests. Tests passed OK --------------- Subject: OK : Zope-2.10 Python-2.4.6 : Linux From: Zope Tests Date: Sun Aug 23 20:44:02 EDT 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-August/012368.html Subject: OK : Zope-2.11 Python-2.4.6 : Linux From: Zope Tests Date: Sun Aug 23 20:46:02 EDT 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-August/012369.html Subject: OK : Zope-2.12 Python-2.4.6 : Linux From: Zope Tests Date: Sun Aug 23 20:48:02 EDT 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-August/012370.html Subject: OK : Zope-2.12 Python-2.6.2 : Linux From: Zope Tests Date: Sun Aug 23 20:50:02 EDT 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-August/012371.html Subject: OK : Zope-2.12-alltests Python-2.4.6 : Linux From: Zope Tests Date: Sun Aug 23 20:52:02 EDT 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-August/012372.html Subject: OK : Zope-2.12-alltests Python-2.6.2 : Linux From: Zope Tests Date: Sun Aug 23 20:54:02 EDT 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-August/012373.html Subject: OK : Zope-trunk Python-2.6.2 : Linux From: Zope Tests Date: Sun Aug 23 20:56:02 EDT 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-August/012374.html Subject: OK : Zope-trunk-alltests Python-2.6.2 : Linux From: Zope Tests Date: Sun Aug 23 20:58:02 EDT 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-August/012375.html

1 0

Zope Tests: 8 OK
by Zope Tests Summarizer 23 Aug '09

23 Aug '09

Summary of messages to the zope-tests list. Period Sat Aug 22 12:00:00 2009 UTC to Sun Aug 23 12:00:00 2009 UTC. There were 8 messages: 8 from Zope Tests. Tests passed OK --------------- Subject: OK : Zope-2.10 Python-2.4.6 : Linux From: Zope Tests Date: Sat Aug 22 20:43:52 EDT 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-August/012360.html Subject: OK : Zope-2.11 Python-2.4.6 : Linux From: Zope Tests Date: Sat Aug 22 20:45:52 EDT 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-August/012361.html Subject: OK : Zope-2.12 Python-2.4.6 : Linux From: Zope Tests Date: Sat Aug 22 20:47:52 EDT 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-August/012362.html Subject: OK : Zope-2.12 Python-2.6.2 : Linux From: Zope Tests Date: Sat Aug 22 20:49:52 EDT 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-August/012363.html Subject: OK : Zope-2.12-alltests Python-2.4.6 : Linux From: Zope Tests Date: Sat Aug 22 20:51:52 EDT 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-August/012364.html Subject: OK : Zope-2.12-alltests Python-2.6.2 : Linux From: Zope Tests Date: Sat Aug 22 20:53:52 EDT 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-August/012365.html Subject: OK : Zope-trunk Python-2.6.2 : Linux From: Zope Tests Date: Sat Aug 22 20:55:52 EDT 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-August/012366.html Subject: OK : Zope-trunk-alltests Python-2.6.2 : Linux From: Zope Tests Date: Sat Aug 22 20:57:52 EDT 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-August/012367.html

1 0

Deprecated code in zope.location
by Fabio Tranchitella 22 Aug '09

22 Aug '09

Hello, we deprecated locationCopy and CopyPersistent from zope.locaton.pickling with the 3.5.3 release (which should have been a new major release, by the way). This introduced a new dependency on zope.deferredimport, but I just realized that according to the decisions taken by the streering group, the right way to deprecate code is to *not* use zope.deferredimport: http://docs.zope.org/zopetoolkit/steeringgroup/decisions.html I thus propose to stop using zope.deferredimport in core ZTK packages, as stated in the page I mentioned above, unless a new decision is made by who is in charge of making decisions. What about removing the use of zope.deferredimport from zope.location and make a new major release of zope.location? Thanks, Fabio

2 3

Zope Tests: 8 OK
by Zope Tests Summarizer 22 Aug '09

22 Aug '09

Summary of messages to the zope-tests list. Period Fri Aug 21 12:00:00 2009 UTC to Sat Aug 22 12:00:00 2009 UTC. There were 8 messages: 8 from Zope Tests. Tests passed OK --------------- Subject: OK : Zope-2.10 Python-2.4.6 : Linux From: Zope Tests Date: Fri Aug 21 20:43:52 EDT 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-August/012352.html Subject: OK : Zope-2.11 Python-2.4.6 : Linux From: Zope Tests Date: Fri Aug 21 20:45:52 EDT 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-August/012353.html Subject: OK : Zope-2.12 Python-2.4.6 : Linux From: Zope Tests Date: Fri Aug 21 20:47:52 EDT 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-August/012354.html Subject: OK : Zope-2.12 Python-2.6.2 : Linux From: Zope Tests Date: Fri Aug 21 20:49:53 EDT 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-August/012355.html Subject: OK : Zope-2.12-alltests Python-2.4.6 : Linux From: Zope Tests Date: Fri Aug 21 20:51:53 EDT 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-August/012356.html Subject: OK : Zope-2.12-alltests Python-2.6.2 : Linux From: Zope Tests Date: Fri Aug 21 20:53:53 EDT 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-August/012357.html Subject: OK : Zope-trunk Python-2.6.2 : Linux From: Zope Tests Date: Fri Aug 21 20:55:53 EDT 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-August/012358.html Subject: OK : Zope-trunk-alltests Python-2.6.2 : Linux From: Zope Tests Date: Fri Aug 21 20:57:53 EDT 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-August/012359.html

1 0

ZTK with no test failures on Python 2.4, 2.5 and 2.6!
by Fabio Tranchitella 21 Aug '09

21 Aug '09

Hello, with the today's changes, the KGS for the Zope Toolkit[1] has no build failures on Python 2.4, 2.5 and 2.6 for both 32bit and 64bit Linux. Kudos to everybody to work to achieve this result! The next steps are: - Add Windows and MacOS build slaves; - Move the kgs definition to a better place than a branch (see [1]). Anyone interested in helping out running build slaves for Windows and MacOS? Running the tests require between 5 and 15 minutes of computation each day (depending on your hardware) and we can arrange the best time to run them for your particular build slave. The only requirement is having Python 2.4, 2.5 and 2.6 installed, better if with a virtualenv environment. If you are interested, please get in touch with me and I will provide you the configuration details. Fabio [1] svn+ssh://svn.zope.org/repos/main/zopetoolkit/branches/jim-kgs/kgs

3 2

Zope Tests: 8 OK
by Zope Tests Summarizer 21 Aug '09

21 Aug '09

Summary of messages to the zope-tests list. Period Thu Aug 20 12:00:00 2009 UTC to Fri Aug 21 12:00:00 2009 UTC. There were 8 messages: 8 from Zope Tests. Tests passed OK --------------- Subject: OK : Zope-2.10 Python-2.4.6 : Linux From: Zope Tests Date: Thu Aug 20 20:43:37 EDT 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-August/012344.html Subject: OK : Zope-2.11 Python-2.4.6 : Linux From: Zope Tests Date: Thu Aug 20 20:45:37 EDT 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-August/012345.html Subject: OK : Zope-2.12 Python-2.4.6 : Linux From: Zope Tests Date: Thu Aug 20 20:47:37 EDT 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-August/012346.html Subject: OK : Zope-2.12 Python-2.6.2 : Linux From: Zope Tests Date: Thu Aug 20 20:49:37 EDT 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-August/012347.html Subject: OK : Zope-2.12-alltests Python-2.4.6 : Linux From: Zope Tests Date: Thu Aug 20 20:51:37 EDT 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-August/012348.html Subject: OK : Zope-2.12-alltests Python-2.6.2 : Linux From: Zope Tests Date: Thu Aug 20 20:53:38 EDT 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-August/012349.html Subject: OK : Zope-trunk Python-2.6.2 : Linux From: Zope Tests Date: Thu Aug 20 20:55:38 EDT 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-August/012350.html Subject: OK : Zope-trunk-alltests Python-2.6.2 : Linux From: Zope Tests Date: Thu Aug 20 20:57:38 EDT 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-August/012351.html

1 0

time.sleep in a boolean check in zope.publisher.http.HTTPRequest.supportsRetry?
by Gary Poster 20 Aug '09

20 Aug '09

Two teams here at Canonical just encountered the STAGGER_RETRIES behavior in http://svn.zope.org/zope.publisher/trunk/src/zope/publisher/http.py?rev=101… . I don't see anything in tests or comments to explain it. Our guess is that it tries to put some breathing room around retries so that the chance of a conflict error might be reduced. In one of our tests setting STAGGER_RETRIES to False reduced a test run from almost 9 minutes to about 1 minute (see https://bugs.edge.launchpad.net/launchpad-foundations/+bug/401586) . We have papered this over in our test suite to no ill effect, giving speed advantages. We wonder if we should remove the behavior entirely, even in production. 1) Why should the time.sleep go into supportsRetry rather than retry? it seems really odd to have it in the method that returns a boolean, rather than the one that does the work. 2) Can someone give some background for this code? Can they give examples of it actually helping anything? We'd like to improve this, minimally by adding some explanatory comments, and maybe by changing, moving, or removing this code. (If anyone tries to do an "annotate" on this, you'll see Jim checked this in back at the dawns of time in rev 8532. On IRC, he didn't recognize this code on a quick look, so he thinks someone else might be more familiar with this.) Gary

2 2

ZTK: upgrade zope.index from 3.5.2 to 3.6.0
by Fabio Tranchitella 20 Aug '09

20 Aug '09

Hello, zope.index 3.5.2 (which is part of the ZTK set) has failing tests on all the supported python versions (2.4, 2.5 and 2.6) on 64 bit platforms. These test failures have been fixed by the 3.6.0 release. I propose to upgrade zope.index from 3.5.2 to 3.6.0 in the KGS; I already ran the ZTK compat tests with this change on Python 2.5 and 2.6 (64 bits) and I have no regressions. After the change I'll also check the buildbot outputs to see if nothing breaks on 32 bits platforms and on Python 2.4. Thanks, Fabio

2 1