- Zope-Dev - Zope lists

Re: [Zope-dev] [Checkins] SVN: z3c.form/branches/icemac_compatibility/ - Made compatible with `zope.app.publisher` 3.8.2
by Michael Howitz 17 Jul '09

17 Jul '09

Am 17.07.2009 um 18:24 schrieb Michael Howitz: > Log message for revision 101967: > - Made compatible with `zope.app.publisher` 3.8.2 (and above) by > using > the new absolute url adapter for resources introduced in 3.8.2. The current trunk of z3c.form is not compatible with zope.app.publisher 3.8.2 and above, as this version introduced an absolute url adapter for resources. This adapter does not exist in versions before 3.8.2. It returns a str instead of a unicode as Resource.__call__ did before. (Relying on this feature seems to be bad anyway.) So my question is whether z3c.form 2.x still has to be compatible with KGS 3.4 of if we can break this compatibility to get compatible with more recent versions of other packages. Trying to stay compatible requires at least some conditional code to register the new absolute url adapter in the tests. Is there any buildbot which tests z3c.form against KGS 3.4 and above? > - Fixed tests to run with `z3c.pt` 1.0b17 (and above) by adding a > missing test dependency on `zope.app.component`. This is necessary because zope.app.component no longer gets pulled in indirectly. But z3c.pt expects zope.app.component to be installed when zope.app.security is installed. (zope.app.security is a test dependency needed by browser/README.txt) zope.app.component is even required for one test (browser/README.txt) of z3c.form. > Changed: > U z3c.form/branches/icemac_compatibility/CHANGES.txt > U z3c.form/branches/icemac_compatibility/buildout.cfg > U z3c.form/branches/icemac_compatibility/setup.py > U z3c.form/branches/icemac_compatibility/src/z3c/form/browser/ > README.txt > U z3c.form/branches/icemac_compatibility/src/z3c/form/browser/ > image.py > U z3c.form/branches/icemac_compatibility/src/z3c/form/button.py > U z3c.form/branches/icemac_compatibility/src/z3c/form/button.txt > > -=- > Modified: z3c.form/branches/icemac_compatibility/CHANGES.txt > =================================================================== > --- z3c.form/branches/icemac_compatibility/CHANGES.txt 2009-07-17 > 16:22:39 UTC (rev 101966) > +++ z3c.form/branches/icemac_compatibility/CHANGES.txt 2009-07-17 > 16:24:27 UTC (rev 101967) > @@ -12,6 +12,13 @@ > manager is only registered for dict, because it would otherwise get > picked up in undesired scenarios. > > +- Made compatible with `zope.app.publisher` 3.8.2 (and above) by > using > + the new absolute url adapter for resources introduced in 3.8.2. > + > +- Fixed tests to run with `z3c.pt` 1.0b17 (and above) by adding a > + missing test dependency on `zope.app.component`. > + > + > Version 2.0.0 (2009-06-14) > -------------------------- > > > Modified: z3c.form/branches/icemac_compatibility/buildout.cfg > =================================================================== > --- z3c.form/branches/icemac_compatibility/buildout.cfg 2009-07-17 > 16:22:39 UTC (rev 101966) > +++ z3c.form/branches/icemac_compatibility/buildout.cfg 2009-07-17 > 16:24:27 UTC (rev 101967) > @@ -2,7 +2,12 @@ > develop = . benchmark > parts = test test-no-z3cpt checker coverage-test coverage-report > docs i18n > benchmark python > +versions = versions > > +[versions] > +zope.app.publisher = 3.8.3 > +z3c.pt = 1.0.0 > + > [test-environment] > CHAMELEON_DEBUG = False > CHAMELEON_CACHE = False > > Modified: z3c.form/branches/icemac_compatibility/setup.py > =================================================================== > --- z3c.form/branches/icemac_compatibility/setup.py 2009-07-17 > 16:22:39 UTC (rev 101966) > +++ z3c.form/branches/icemac_compatibility/setup.py 2009-07-17 > 16:24:27 UTC (rev 101967) > @@ -91,6 +91,8 @@ > 'zope.app.testing', > 'zope.container', > 'zope.testing', > + 'zope.app.component', # required by z3c.pt from 1.0b17 on > + # also required by our browser/ > README.txt > ], > adding = ['zope.app.container'], > docs = ['z3c.recipe.sphinxdoc'], > > Modified: z3c.form/branches/icemac_compatibility/src/z3c/form/ > browser/README.txt > =================================================================== > --- z3c.form/branches/icemac_compatibility/src/z3c/form/browser/ > README.txt 2009-07-17 16:22:39 UTC (rev 101966) > +++ z3c.form/branches/icemac_compatibility/src/z3c/form/browser/ > README.txt 2009-07-17 16:24:27 UTC (rev 101967) > @@ -500,6 +500,14 @@ >>>> zope.component.provideAdapter( > ... resource, (None, None), ITraversable, name="resource") > > + # Register resource absolute url adapter > + >>> import zope.app.publisher.browser.resource > + >>> from zope.app.publisher.interfaces import IResource > + >>> import zope.traversing.browser.interfaces > + >>> zope.component.provideAdapter( > + ... zope.app.publisher.browser.resource.AbsoluteURL, > (IResource, None), > + ... zope.traversing.browser.interfaces.IAbsoluteURL) > + > # Register the "pressme.png" resource >>>> from zope.app.publisher.browser.resource import Resource >>>> testing.browserResource('pressme.png', Resource) > > Modified: z3c.form/branches/icemac_compatibility/src/z3c/form/ > browser/image.py > =================================================================== > --- z3c.form/branches/icemac_compatibility/src/z3c/form/browser/ > image.py 2009-07-17 16:22:39 UTC (rev 101966) > +++ z3c.form/branches/icemac_compatibility/src/z3c/form/browser/ > image.py 2009-07-17 16:24:27 UTC (rev 101967) > @@ -51,6 +51,6 @@ > image.value = field.title > # Get the full resource URL for the image: > site = hooks.getSite() > - image.src = zope.traversing.api.traverse( > - site, '++resource++' + field.image, request=request)() > + image.src = unicode(zope.traversing.api.traverse( > + site, '++resource++' + field.image, request=request)()) > return image > > Modified: z3c.form/branches/icemac_compatibility/src/z3c/form/ > button.py > =================================================================== > --- z3c.form/branches/icemac_compatibility/src/z3c/form/button.py > 2009-07-17 16:22:39 UTC (rev 101966) > +++ z3c.form/branches/icemac_compatibility/src/z3c/form/button.py > 2009-07-17 16:24:27 UTC (rev 101967) > @@ -234,8 +234,8 @@ > @property > def src(self): > site = hooks.getSite() > - src = zope.traversing.api.traverse( > - site, '++resource++' + self.field.image, > request=self.request)() > + src = unicode(zope.traversing.api.traverse( > + site, '++resource++' + self.field.image, > request=self.request)()) > return src > > def isExecuted(self): > > Modified: z3c.form/branches/icemac_compatibility/src/z3c/form/ > button.txt > =================================================================== > --- z3c.form/branches/icemac_compatibility/src/z3c/form/button.txt > 2009-07-17 16:22:39 UTC (rev 101966) > +++ z3c.form/branches/icemac_compatibility/src/z3c/form/button.txt > 2009-07-17 16:24:27 UTC (rev 101967) > @@ -644,6 +644,14 @@ >>>> zope.component.provideAdapter( > ... resource, (None, None), ITraversable, name="resource") > > + # Register resource absolute url adapter > + >>> import zope.app.publisher.browser.resource > + >>> from zope.app.publisher.interfaces import IResource > + >>> import zope.traversing.browser.interfaces > + >>> zope.component.provideAdapter( > + ... zope.app.publisher.browser.resource.AbsoluteURL, > (IResource, None), > + ... zope.traversing.browser.interfaces.IAbsoluteURL) > + > # Register the "submit.png" resource >>>> from zope.app.publisher.browser.resource import Resource >>>> testing.browserResource('submit.png', Resource) Yours sincerely, -- Michael Howitz · mh(a)gocept.com · software developer gocept gmbh & co. kg · forsterstraße 29 · 06112 halle (saale) · germany http://gocept.com · tel +49 345 1229889 8 · fax +49 345 1229889 1 Zope and Plone consulting and development

2 1

z3c.recipe.i18n and zope.app.locales.extract
by yuppie 17 Jul '09

17 Jul '09

Hi! I plan to use z3c.recipe.i18n for some Zope 2 CMF products. But to get things working I did have to modify z3c.recipe.i18n a bit. It would be nice if I could get some feedback regarding the issues I found: 1.) running tests ----------------- test.py tries to install 'zodbcode' and 'zope.app.interface'. That doesn't work for me. AFAICS those two eggs are no longer indirect testing dependencies. After removing those two lines all tests pass. Proposal: Remove those two lines in test.py. 2.) looking up the product version ---------------------------------- POTMaker._getProductVersion() doesn't work for me. zope.app.applicationcontrol is not used by Zope 2 and is not part of the specified dependencies. This raises an error. Proposal: Catch the error. Return an empty string if version is not found. 3.) customizing the .pot header ------------------------------- POTMaker.write() uses a harcoded Zope 3 specific pot_header template. Proposal: The easiest and most flexible way to customize this seems to be an option that allows to specify a file that contains the pot_header template. 4.) looking up basePath ----------------------- i18nextract.main() contains these lines: # add maker for each given path for pkgName, path in eggPaths: srcIdx = path.rfind('src') if srcIdx == -1: # this is an egg package, strip down base path basePath = path moduleNames = pkgName.split('.') moduleNames.reverse() for mName in moduleNames: mIdx = path.rfind(mName) basePath = basePath[:mIdx] pkgPath = path[len(basePath):] else: # this is a package linked in as externals basePath = path[:srcIdx] pkgPath = path[len(basePath):] I don't understand why we need different code for "packages linked in as externals". The "egg package" code works actually better for linked in packages that don't follow the 'src' convention. Proposal: Use the 'if' code for all packages. 5. writing makers ----------------- I'd like to specify additional makers. This is a nice hook, but why are only these three arguments passed to custom poMakers? maker.add(poMaker(path, basePath, exclude_dirs), basePath) I miss 'domain' and 'include_default_domain'. Proposal: Pass in the additional arguments and fall back to the old signature for BBB. Does all that make sense? Any objections or better ideas? Should changes for POTMaker go into zope.app.locales.extract or should z3c.recipe.i18n use a customized version? Cheers, Yuppie

2 7

Zope Tests: 2 OK, 4 Failed
by Zope Tests Summarizer 17 Jul '09

17 Jul '09

Summary of messages to the zope-tests list. Period Thu Jul 16 12:00:00 2009 UTC to Fri Jul 17 12:00:00 2009 UTC. There were 6 messages: 6 from Zope Tests. Test failures ------------- Subject: FAILED (failures=1) : Zope-2.12 Python-2.6.2 : Linux From: Zope Tests Date: Thu Jul 16 20:41:53 EDT 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-July/012075.html Subject: FAILED (failures=7) : Zope-2.12-alltests Python-2.6.2 : Linux From: Zope Tests Date: Thu Jul 16 20:43:53 EDT 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-July/012076.html Subject: FAILED (failures=1) : Zope-trunk Python-2.6.2 : Linux From: Zope Tests Date: Thu Jul 16 20:45:53 EDT 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-July/012077.html Subject: FAILED (failures=7) : Zope-trunk-alltests Python-2.6.2 : Linux From: Zope Tests Date: Thu Jul 16 20:47:53 EDT 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-July/012078.html Tests passed OK --------------- Subject: OK : Zope-2.10 Python-2.4.6 : Linux From: Zope Tests Date: Thu Jul 16 20:37:53 EDT 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-July/012073.html Subject: OK : Zope-2.11 Python-2.4.6 : Linux From: Zope Tests Date: Thu Jul 16 20:39:53 EDT 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-July/012074.html

1 0

Zope Tests: 2 OK, 4 Failed
by Zope Tests Summarizer 16 Jul '09

16 Jul '09

Summary of messages to the zope-tests list. Period Wed Jul 15 12:00:00 2009 UTC to Thu Jul 16 12:00:00 2009 UTC. There were 6 messages: 6 from Zope Tests. Test failures ------------- Subject: FAILED (failures=1) : Zope-2.12 Python-2.6.2 : Linux From: Zope Tests Date: Wed Jul 15 20:41:34 EDT 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-July/012069.html Subject: FAILED (failures=7) : Zope-2.12-alltests Python-2.6.2 : Linux From: Zope Tests Date: Wed Jul 15 20:43:34 EDT 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-July/012070.html Subject: FAILED (failures=1) : Zope-trunk Python-2.6.2 : Linux From: Zope Tests Date: Wed Jul 15 20:45:34 EDT 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-July/012071.html Subject: FAILED (failures=7) : Zope-trunk-alltests Python-2.6.2 : Linux From: Zope Tests Date: Wed Jul 15 20:47:34 EDT 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-July/012072.html Tests passed OK --------------- Subject: OK : Zope-2.10 Python-2.4.6 : Linux From: Zope Tests Date: Wed Jul 15 20:37:34 EDT 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-July/012067.html Subject: OK : Zope-2.11 Python-2.4.6 : Linux From: Zope Tests Date: Wed Jul 15 20:39:34 EDT 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-July/012068.html

1 0

zope.release's bin/upload
by Marius Gedminas 15 Jul '09

15 Jul '09

Consider this: $ svn info | grep URL URL: svn+ssh://svn.zope.org/repos/main/zope.release/branches/3.4 $ bin/buildout ... $ bin/upload str(object) -> string Return a nice string representation of the object. If the argument is a string, the return value is the same object. Can somebody explain to me what's happening here? Marius Gedminas -- http://pov.lt/ -- Zope 3 consulting and development

1 0

utilities and python version in zope2.12
by Jonas Meurer 15 Jul '09

15 Jul '09

Hello, I just recognized that lots of utilities in zope2.12 still do have python2.4 as interpreter while the release notes of zope2.12 talk about python2.5 and python2.6 being the only supported python versions. greetings, jonas

3 7

zope.testing 3.7.7 released
by Christian Theune 15 Jul '09

15 Jul '09

Hi, I just released zope.testing 3.7.7. It contains two interesting changes: - The test runner now correctly does *not* descend into `test-path`s which are not Python packages. This solves an issue with eggs being picked up when run from buildout directories which both contained the develop egg without an additional source directory and the egg directory. - The code for using zope.exceptions exception formatters was handled incompletely and very ad-hoc. The dependency was folded from an extra into a direct dependency and the formatters are now used per default and work for doctests as well. This should make debugging page template issues (e.g. with the testbrowser) a lot easier. Cheers, Christian -- Christian Theune · ct(a)gocept.com gocept gmbh & co. kg · forsterstraße 29 · 06112 halle (saale) · germany http://gocept.com · tel +49 345 1229889 0 · fax +49 345 1229889 1 Zope and Plone consulting and development

2 1

test setup layer sorting
by Reinout van Rees 14 Jul '09

14 Jul '09

zope/testing/testrunner/runner.py's order_by_bases() function orders layers by inheritance, basically. So if you've got a FunctionalTestLayer that inherits from some BasicTestLayer, the tests that use the basic test layer will be executed before the functional test layer ones. If there's no inheritance, the layers are sorted by name. Quite sane. Problem: I use grok. Which does some magic that probably throws off the code coverage reports. Quite some code appears untested, even though I *do* test it. The problem disappears if just import the python module first in some basic test before the grokking happened. I use z3c.testsetup: - My basic doctests end up on the zope.testing.testrunner.layer.UnitTests layer. - My functional doctests on the z3c.testsetup.functional.layer.DefaultZCMLLayer layer which inherits from zope.app.testing's ZCMLLayer. - zope.app.testing's ZCMLLayer does not inherit from anything, so also not from zope.testing's unittest layer. - 'zope....' is alphabetically behind 'z3c.testsetup....', so the functional layer is sorted in front of the basic unittest one. - So my grokked code appears untested. What's the best solution? Should zope.app.testing's ZCMLLayer inherit from zope.testing's UnitTests layer? Should z3c.testsetup do some inheriting of its own? Reinout -- Reinout van Rees - reinout(a)vanrees.org - http://reinout.vanrees.org Software developer at http://www.thehealthagency.com "Military engineers build missiles. Civil engineers build targets"

4 7

z3c.form: data manager for PersistentDict/PersistentMapping
by Michael Howitz 14 Jul '09

14 Jul '09

Hello, z3c.form.datamanager.DictionaryField is a data manager which is registered for fields on a dict. In its __init__ it checks whether the data object is an instance of dict. So this data manager does neither work for UserDict nor PersistentDict/PersistentMapping. I'd like to change this but there are two possibilities and I'm not sure which is the best one: 1.) Add a subclasses of DictionaryField which is registered for UserDict and which checks whether the data object is an instance of UserDict. (PersistentDict and PersistentMapping are subclasses of UserDict.) 2.) Register DictionaryField for zope.interface.common.mapping.IMapping. This might have a problem as neither UserDict nor PersistentDict/PersistentMapping seem to provide this interface. (Why?) Any suggestions? Yours sincerely, -- Michael Howitz · mh(a)gocept.com · software developer gocept gmbh & co. kg · forsterstraße 29 · 06112 halle (saale) · germany http://gocept.com · tel +49 345 1229889 8 · fax +49 345 1229889 1 Zope and Plone consulting and development

3 5

Creating new five.* package
by Thomas Lotze 13 Jul '09

13 Jul '09

We've started a new package, five.hashedresource, that is supposed to integrate z3c.hashedresource into Zope2. Just to make sure not to step on someone's toes: is it OK to just create such a package in that namespace? -- Thomas

2 1