- Zope-Dev - Zope lists

Is "if sys.exc_info()[2].tb_next is not None: raise" Evil? Concerns Products.GenericSetup, zope.configuration and others
by Ross Patterson 03 Aug '07

03 Aug '07

While trying to use zope.app.modul.ZopePersistentModuleImporter, I ran across an interaction with code that uses the following hack to try and discern where an exception was raised. >>> if sys.exc_info()[2].tb_next is not None: >>> raise The problem is occurs when an application provides an __import__ function written in python. In that case then there is a tb_next for all ImportError exceptions and this hack no longer indicates when the error was deeper. The same problem would occur if the hack were used while catching AttributeError and there was a python implementation for attribute access involved. This hack counts on the fact that C code which raises an error doesn't get included in the stack. It counts on this fact, however, at points where Python specifically allows application specific implementations written in Python. See the first paragraph of the __import__ documentation. http://docs.python.org/lib/built-in-funcs.html#l2h-6 Here's a grep of the Zope 2.10 branch. These first two are catching TypeError: ./Zope/lib/python/zope/component/_api.py:73: if sys.exc_info()[2].tb_next is not None: ./Zope/lib/python/zope/interface/interface.py:644: if sys.exc_info()[2].tb_next is not None: And these are catching ImportError: ./Zope/lib/python/zope/configuration/config.py:186: if sys.exc_info()[2].tb_next is not None: ./Zope/lib/python/zope/configuration/config.py:208: if sys.exc_info()[2].tb_next is not None: For zope.configuration.config.ConfigurationContext.resolve, this hack makes the difference between an ImportError being raised or a ConfigurationError. This inturn interacts with zope.app.component.back35.LayerField.fromUnicode which only catches ConfigurationError and doesn't catch ImportError. And here's the GenericSetup 1.3 branch, it is also catching ImportError: ./Products/GenericSetup/utils.py:89: if sys.exc_info()[2].tb_next is not None: raise Products.GenericSetup.utils._resolveDottedName is particularly troublesome since the except ImportError is inside a while loop so when __import__ is a python function and it raises ImportError, _resolveDottedName ends up not continuing with the while loop as it should. It seems like the root of the problem is that Python doesn't provide a way to distinguish between an error and a deeper error of the same type. This hack is trying to make that distinction but it interferes with places that Python specifically allows application specific implementations written in Python. Does that mean that code using this hack is broken? Also, zope.dottedname.resolve.resolve, zope.app.introspector.resolve, zope.app.component.site.resolve, zope.app.module.resolve, zope.configuration.name.resolve, zope.configuration.config.ConfigurationContext.resolve, Products.GenericSetup.utils._resolveDottedName. How many versions of this wheel do we need? :) Thoughts? Corrections? Suggested solutions. Ross

1 0

Zope Tests: 5 OK
by Zope Tests Summarizer 03 Aug '07

03 Aug '07

Summary of messages to the zope-tests list. Period Thu Aug 2 12:00:00 2007 UTC to Fri Aug 3 12:00:00 2007 UTC. There were 5 messages: 5 from Zope Unit Tests. Tests passed OK --------------- Subject: OK : Zope-2.7 Python-2.3.6 : Linux From: Zope Unit Tests Date: Thu Aug 2 20:53:58 EDT 2007 URL: http://mail.zope.org/pipermail/zope-tests/2007-August/008127.html Subject: OK : Zope-2.8 Python-2.3.6 : Linux From: Zope Unit Tests Date: Thu Aug 2 20:55:29 EDT 2007 URL: http://mail.zope.org/pipermail/zope-tests/2007-August/008128.html Subject: OK : Zope-2.9 Python-2.4.4 : Linux From: Zope Unit Tests Date: Thu Aug 2 20:56:59 EDT 2007 URL: http://mail.zope.org/pipermail/zope-tests/2007-August/008129.html Subject: OK : Zope-2.10 Python-2.4.4 : Linux From: Zope Unit Tests Date: Thu Aug 2 20:58:30 EDT 2007 URL: http://mail.zope.org/pipermail/zope-tests/2007-August/008130.html Subject: OK : Zope-trunk Python-2.4.4 : Linux From: Zope Unit Tests Date: Thu Aug 2 21:00:02 EDT 2007 URL: http://mail.zope.org/pipermail/zope-tests/2007-August/008131.html

1 0

Zope Tests: 5 OK
by Zope Tests Summarizer 02 Aug '07

02 Aug '07

Summary of messages to the zope-tests list. Period Wed Aug 1 12:00:00 2007 UTC to Thu Aug 2 12:00:00 2007 UTC. There were 5 messages: 5 from Zope Unit Tests. Tests passed OK --------------- Subject: OK : Zope-2.7 Python-2.3.6 : Linux From: Zope Unit Tests Date: Wed Aug 1 20:52:55 EDT 2007 URL: http://mail.zope.org/pipermail/zope-tests/2007-August/008122.html Subject: OK : Zope-2.8 Python-2.3.6 : Linux From: Zope Unit Tests Date: Wed Aug 1 20:54:26 EDT 2007 URL: http://mail.zope.org/pipermail/zope-tests/2007-August/008123.html Subject: OK : Zope-2.9 Python-2.4.4 : Linux From: Zope Unit Tests Date: Wed Aug 1 20:55:57 EDT 2007 URL: http://mail.zope.org/pipermail/zope-tests/2007-August/008124.html Subject: OK : Zope-2.10 Python-2.4.4 : Linux From: Zope Unit Tests Date: Wed Aug 1 20:57:28 EDT 2007 URL: http://mail.zope.org/pipermail/zope-tests/2007-August/008125.html Subject: OK : Zope-trunk Python-2.4.4 : Linux From: Zope Unit Tests Date: Wed Aug 1 20:59:00 EDT 2007 URL: http://mail.zope.org/pipermail/zope-tests/2007-August/008126.html

1 0

Zope Tests: 5 OK
by Zope Tests Summarizer 01 Aug '07

01 Aug '07

Summary of messages to the zope-tests list. Period Tue Jul 31 12:00:00 2007 UTC to Wed Aug 1 12:00:00 2007 UTC. There were 5 messages: 5 from Zope Unit Tests. Tests passed OK --------------- Subject: OK : Zope-2.7 Python-2.3.6 : Linux From: Zope Unit Tests Date: Tue Jul 31 20:53:26 EDT 2007 URL: http://mail.zope.org/pipermail/zope-tests/2007-July/008117.html Subject: OK : Zope-2.8 Python-2.3.6 : Linux From: Zope Unit Tests Date: Tue Jul 31 20:54:57 EDT 2007 URL: http://mail.zope.org/pipermail/zope-tests/2007-July/008118.html Subject: OK : Zope-2.9 Python-2.4.4 : Linux From: Zope Unit Tests Date: Tue Jul 31 20:56:28 EDT 2007 URL: http://mail.zope.org/pipermail/zope-tests/2007-July/008119.html Subject: OK : Zope-2.10 Python-2.4.4 : Linux From: Zope Unit Tests Date: Tue Jul 31 20:57:59 EDT 2007 URL: http://mail.zope.org/pipermail/zope-tests/2007-July/008120.html Subject: OK : Zope-trunk Python-2.4.4 : Linux From: Zope Unit Tests Date: Tue Jul 31 20:59:30 EDT 2007 URL: http://mail.zope.org/pipermail/zope-tests/2007-July/008121.html

1 0

Zope Tests: 5 OK
by Zope Tests Summarizer 30 Jul '07

30 Jul '07

Summary of messages to the zope-tests list. Period Sun Jul 29 12:00:00 2007 UTC to Mon Jul 30 12:00:00 2007 UTC. There were 5 messages: 5 from Zope Unit Tests. Tests passed OK --------------- Subject: OK : Zope-2.7 Python-2.3.6 : Linux From: Zope Unit Tests Date: Sun Jul 29 20:54:55 EDT 2007 URL: http://mail.zope.org/pipermail/zope-tests/2007-July/008107.html Subject: OK : Zope-2.8 Python-2.3.6 : Linux From: Zope Unit Tests Date: Sun Jul 29 20:56:31 EDT 2007 URL: http://mail.zope.org/pipermail/zope-tests/2007-July/008108.html Subject: OK : Zope-2.9 Python-2.4.4 : Linux From: Zope Unit Tests Date: Sun Jul 29 20:58:04 EDT 2007 URL: http://mail.zope.org/pipermail/zope-tests/2007-July/008109.html Subject: OK : Zope-2.10 Python-2.4.4 : Linux From: Zope Unit Tests Date: Sun Jul 29 20:59:36 EDT 2007 URL: http://mail.zope.org/pipermail/zope-tests/2007-July/008110.html Subject: OK : Zope-trunk Python-2.4.4 : Linux From: Zope Unit Tests Date: Sun Jul 29 21:01:08 EDT 2007 URL: http://mail.zope.org/pipermail/zope-tests/2007-July/008111.html

1 0

Zope Tests: 5 OK
by Zope Tests Summarizer 29 Jul '07

29 Jul '07

Summary of messages to the zope-tests list. Period Sat Jul 28 12:00:00 2007 UTC to Sun Jul 29 12:00:00 2007 UTC. There were 5 messages: 5 from Zope Unit Tests. Tests passed OK --------------- Subject: OK : Zope-2.7 Python-2.3.6 : Linux From: Zope Unit Tests Date: Sat Jul 28 20:53:10 EDT 2007 URL: http://mail.zope.org/pipermail/zope-tests/2007-July/008102.html Subject: OK : Zope-2.8 Python-2.3.6 : Linux From: Zope Unit Tests Date: Sat Jul 28 20:54:41 EDT 2007 URL: http://mail.zope.org/pipermail/zope-tests/2007-July/008103.html Subject: OK : Zope-2.9 Python-2.4.4 : Linux From: Zope Unit Tests Date: Sat Jul 28 20:56:14 EDT 2007 URL: http://mail.zope.org/pipermail/zope-tests/2007-July/008104.html Subject: OK : Zope-2.10 Python-2.4.4 : Linux From: Zope Unit Tests Date: Sat Jul 28 20:57:49 EDT 2007 URL: http://mail.zope.org/pipermail/zope-tests/2007-July/008105.html Subject: OK : Zope-trunk Python-2.4.4 : Linux From: Zope Unit Tests Date: Sat Jul 28 20:59:23 EDT 2007 URL: http://mail.zope.org/pipermail/zope-tests/2007-July/008106.html

1 0

Zope Tests: 5 OK
by Zope Tests Summarizer 28 Jul '07

28 Jul '07

Summary of messages to the zope-tests list. Period Fri Jul 27 12:00:00 2007 UTC to Sat Jul 28 12:00:00 2007 UTC. There were 5 messages: 5 from Zope Unit Tests. Tests passed OK --------------- Subject: OK : Zope-2.7 Python-2.3.6 : Linux From: Zope Unit Tests Date: Fri Jul 27 20:55:28 EDT 2007 URL: http://mail.zope.org/pipermail/zope-tests/2007-July/008097.html Subject: OK : Zope-2.8 Python-2.3.6 : Linux From: Zope Unit Tests Date: Fri Jul 27 20:56:59 EDT 2007 URL: http://mail.zope.org/pipermail/zope-tests/2007-July/008098.html Subject: OK : Zope-2.9 Python-2.4.4 : Linux From: Zope Unit Tests Date: Fri Jul 27 20:58:30 EDT 2007 URL: http://mail.zope.org/pipermail/zope-tests/2007-July/008099.html Subject: OK : Zope-2.10 Python-2.4.4 : Linux From: Zope Unit Tests Date: Fri Jul 27 21:00:01 EDT 2007 URL: http://mail.zope.org/pipermail/zope-tests/2007-July/008100.html Subject: OK : Zope-trunk Python-2.4.4 : Linux From: Zope Unit Tests Date: Fri Jul 27 21:01:32 EDT 2007 URL: http://mail.zope.org/pipermail/zope-tests/2007-July/008101.html

1 0

Zope Tests: 5 OK
by Zope Tests Summarizer 27 Jul '07

27 Jul '07

Summary of messages to the zope-tests list. Period Thu Jul 26 12:00:00 2007 UTC to Fri Jul 27 12:00:00 2007 UTC. There were 5 messages: 5 from Zope Unit Tests. Tests passed OK --------------- Subject: OK : Zope-2.7 Python-2.3.6 : Linux From: Zope Unit Tests Date: Thu Jul 26 20:52:24 EDT 2007 URL: http://mail.zope.org/pipermail/zope-tests/2007-July/008092.html Subject: OK : Zope-2.8 Python-2.3.6 : Linux From: Zope Unit Tests Date: Thu Jul 26 20:53:57 EDT 2007 URL: http://mail.zope.org/pipermail/zope-tests/2007-July/008093.html Subject: OK : Zope-2.9 Python-2.4.4 : Linux From: Zope Unit Tests Date: Thu Jul 26 20:55:28 EDT 2007 URL: http://mail.zope.org/pipermail/zope-tests/2007-July/008094.html Subject: OK : Zope-2.10 Python-2.4.4 : Linux From: Zope Unit Tests Date: Thu Jul 26 20:56:59 EDT 2007 URL: http://mail.zope.org/pipermail/zope-tests/2007-July/008095.html Subject: OK : Zope-trunk Python-2.4.4 : Linux From: Zope Unit Tests Date: Thu Jul 26 20:58:30 EDT 2007 URL: http://mail.zope.org/pipermail/zope-tests/2007-July/008096.html

1 0

Zope Tests: 5 OK
by Zope Tests Summarizer 26 Jul '07

26 Jul '07

Summary of messages to the zope-tests list. Period Wed Jul 25 12:00:00 2007 UTC to Thu Jul 26 12:00:00 2007 UTC. There were 5 messages: 5 from Zope Unit Tests. Tests passed OK --------------- Subject: OK : Zope-2.7 Python-2.3.6 : Linux From: Zope Unit Tests Date: Wed Jul 25 20:52:52 EDT 2007 URL: http://mail.zope.org/pipermail/zope-tests/2007-July/008087.html Subject: OK : Zope-2.8 Python-2.3.6 : Linux From: Zope Unit Tests Date: Wed Jul 25 20:54:23 EDT 2007 URL: http://mail.zope.org/pipermail/zope-tests/2007-July/008088.html Subject: OK : Zope-2.9 Python-2.4.4 : Linux From: Zope Unit Tests Date: Wed Jul 25 20:55:54 EDT 2007 URL: http://mail.zope.org/pipermail/zope-tests/2007-July/008089.html Subject: OK : Zope-2.10 Python-2.4.4 : Linux From: Zope Unit Tests Date: Wed Jul 25 20:57:24 EDT 2007 URL: http://mail.zope.org/pipermail/zope-tests/2007-July/008090.html Subject: OK : Zope-trunk Python-2.4.4 : Linux From: Zope Unit Tests Date: Wed Jul 25 20:58:55 EDT 2007 URL: http://mail.zope.org/pipermail/zope-tests/2007-July/008091.html

1 0

Zope Tests: 5 OK
by Zope Tests Summarizer 25 Jul '07

25 Jul '07

Summary of messages to the zope-tests list. Period Tue Jul 24 12:00:00 2007 UTC to Wed Jul 25 12:00:00 2007 UTC. There were 5 messages: 5 from Zope Unit Tests. Tests passed OK --------------- Subject: OK : Zope-2.7 Python-2.3.6 : Linux From: Zope Unit Tests Date: Tue Jul 24 20:51:52 EDT 2007 URL: http://mail.zope.org/pipermail/zope-tests/2007-July/008082.html Subject: OK : Zope-2.8 Python-2.3.6 : Linux From: Zope Unit Tests Date: Tue Jul 24 20:53:23 EDT 2007 URL: http://mail.zope.org/pipermail/zope-tests/2007-July/008083.html Subject: OK : Zope-2.9 Python-2.4.4 : Linux From: Zope Unit Tests Date: Tue Jul 24 20:54:55 EDT 2007 URL: http://mail.zope.org/pipermail/zope-tests/2007-July/008084.html Subject: OK : Zope-2.10 Python-2.4.4 : Linux From: Zope Unit Tests Date: Tue Jul 24 20:56:26 EDT 2007 URL: http://mail.zope.org/pipermail/zope-tests/2007-July/008085.html Subject: OK : Zope-trunk Python-2.4.4 : Linux From: Zope Unit Tests Date: Tue Jul 24 20:58:00 EDT 2007 URL: http://mail.zope.org/pipermail/zope-tests/2007-July/008086.html

1 0