Zope-Dev

zope-dev@zope.dev

October 2005

23 participants
42 discussions

Allowing @ in object ids
by Florent Guillaume 04 Oct '05

04 Oct '05

Today @ is forbidden in object ids. That's controlled by the bad_id regexp in OFS.ObjectManager, which tries to ensure that ids will be useable as URL components. However, there's no reason to disallow this, as the URL spec (http:// www.ietf.org/rfc/rfc1738.txt) says: An HTTP URL takes the form: http://<host>:<port>/<path>?<searchpart> [...] Within the <path> and <searchpart> components, "/", ";", "?" are reserved. The "/" character may be used within HTTP to designate a hierarchical structure. Note that somewhere else in the spec, it says that @ (and others) MAY be reserved by some schemes, but HTTP doesn't actually make it reserved. Furthermore, many projects have monkey-patched bad_id to allow @ and see no ill-effects. Having @ in ids is very useful for various things, one of them being to have email-like identifiers (think jabber for instance). There are other uses. Unless there's opposition, I'll change the code to allow it. Florent -- Florent Guillaume, Nuxeo (Paris, France) CTO, Director of R&D +33 1 40 33 71 59 http://nuxeo.com fg(a)nuxeo.com

1 1

Zope 2 trunk OFS tests failing
by Florent Guillaume 04 Oct '05

04 Oct '05

The OFS.testObjectManager tests are failing when run in isolation on the Zope 2 trunk (also on the 2.8 branch). Any idea? I'll look at it anyway, but if someone's seen this already... bin/zopectl test -v --libdir lib/python --dir lib/python/OFS testObjectManager ....E........F..... ====================================================================== ERROR: test_delObject_exception_debug_manager (OFS.tests.testObjectManager.ObjectManagerTests) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/fguillaume/zope/zope2/lib/python/OFS/tests/ testObjectManager.py", line 290, in test_delObject_exception_debug_manager om._delObject(ob.getId()) File "/Users/fguillaume/zope/zope2/lib/python/OFS/ ObjectManager.py", line 350, in _delObject if not getSecurityManager().getUser().has_role('Manager'): AttributeError: 'NoneType' object has no attribute 'has_role' ====================================================================== FAIL: test_setObject_set_owner_with_emergency_user (OFS.tests.testObjectManager.ObjectManagerTests) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/fguillaume/zope/zope2/lib/python/OFS/tests/ testObjectManager.py", line 104, in test_setObject_set_owner_with_emergency_user , om._setObject, 'should_fail', si ) File "/usr/local/lib/python2.3/unittest.py", line 295, in failUnlessRaises raise self.failureException, excName AssertionError: EmergencyUserCannotOwn ---------------------------------------------------------------------- Ran 19 tests in 0.077s Florent -- Florent Guillaume, Nuxeo (Paris, France) Director of R&D +33 1 40 33 71 59 http://nuxeo.com fg(a)nuxeo.com

2 2