- Zope-Dev - Zope lists

Review of zc.dict tlotze-blist branch
by Gary Poster 24 Feb '09

24 Feb '09

[Thomas asked me to review his zc.dict branch a while ago.] Hi Thomas. Thank you for this work. It looks great. I do have several comments below (from an abbreviated diff against the current trunk). > Index: buildout.cfg > =================================================================== > --- buildout.cfg (.../trunk) (revision 97211) > +++ buildout.cfg (.../branches/tlotze-blist) (revision 97211) > @@ -2,11 +2,10 @@ > develop = . > parts = test py > > -find-links = http://download.zope.org/distribution/ > - > [test] > recipe = zc.recipe.testrunner > -eggs = zc.dict > +eggs = zc.dict [generations] > +defaults = ["-v", "-c"] I don't think the generations code should be required, and (since you used extras_require) neither do you. Therefore I'd prefer it if the main tests also didn't depend on that code. The way I've done this with other packages (e.g. http://svn.zope.org/zc.async/trunk/buildout.cfg?view=auto) is to have multiple test sections (with different names). The downside is that then, to run all possible tests, you have to run more than one command. The upside is that arguably the most important configuration--the base one--is truly tested. > > [py] > recipe = zc.recipe.egg > Index: CHANGES.txt > =================================================================== > --- CHANGES.txt (.../trunk) (revision 97211) > +++ CHANGES.txt (.../branches/tlotze-blist) (revision 97211) > @@ -1,3 +1,8 @@ > +1.3 (unreleased) > +---------------- > + > +* changed the implementation of OrderedDict to store the order in buckets I suggest adding "via zc.blist" or something like that. ... > Index: src/zc/dict/configure.zcml > =================================================================== > --- src/zc/dict/configure.zcml (.../trunk) (revision 0) > +++ src/zc/dict/configure.zcml (.../branches/tlotze-blist) (revision 97211) > @@ -0,0 +1,5 @@ > +<configure xmlns="http://namespaces.zope.org/zope"> > + > + <include package=".generations" /> > + > +</configure> configure.zcml has a semantic of "always include." Because the generations code may not work for many people (as we've discussed before, and see comment in evolve test below), I'd prefer that the generations code have a semantic of "optionally include." Therefore, I suggest you rename this to "generations.zcml" or something like that. ... > Index: src/zc/dict/dict.py > =================================================================== > --- src/zc/dict/dict.py (.../trunk) (revision 97211) > +++ src/zc/dict/dict.py (.../branches/tlotze-blist) (revision 97211) ... > def __setitem__(self, key, value): > - delta = 1 > - if key in self._data: > - delta = 0 > - self._data[key] = value > - if delta: > + if key not in self._data: > self._order.append(key) > - self._len.change(delta) > + self._len.change(1) > + self._data[key] = value Nice improvement in readability. > > def updateOrder(self, order): ... Also as mentioned before on the Zope list, until this API is deprecated in favor of one that encourages more granular changes, the change to blist only really helps the story for adding new items to an ordered dict. The Plone IExplicitOrdering interface looks reasonable, and could really take advantage of the blist characteristics. http://dev.plone.org/plone/browser/plone.folder/trunk/plone/folder/interfac… > Index: src/zc/dict/generations/evolve1.txt > =================================================================== > --- src/zc/dict/generations/evolve1.txt (.../trunk) (revision 0) > +++ src/zc/dict/generations/evolve1.txt (.../branches/tlotze-blist) ... As we discussed earlier, findObjectsMatching will miss OrderedDicts that are used as internal data structures. I regard that as a primary use case for this package, so IMO that's important to note in the doc and in the Python file. Otherwise, looks great to me. Thank you! Gary

1 0

Re: [Zope-dev] [Checkins] SVN: z3c.mimetype/ Create infrastructure for z3c.mimetype
by Benji York 24 Feb '09

24 Feb '09

On Tue, Feb 24, 2009 at 8:29 AM, Dan Korostelev <nadako(a)gmail.com> wrote: > 2009/2/24 Baiju M <mbaiju(a)zeomega.net>: >> Hi Dan, >> >> On Tue, Feb 24, 2009 at 6:40 PM, Dan Korostelev <nadako(a)gmail.com> wrote: >>> Log message for revision 97207: >>> Create infrastructure for z3c.mimetype >>> >>> Changed: >>> A z3c.mimetype/ >> >> I thought of sharing this with you, may be useful. I have got one tip from >> Jim for creating a new project area: >> http://mail.zope.org/pipermail/zope3-dev/2006-October/020701.html > > Heh, nice trick with `z` :) Thank you. A slight refinement: svn mkdir path-to-repo/new-project{,trunk,tags,branches} Using the `z` trick, that would be: svn mkdir `z`/new-project{,trunk,tags,branches} -- Benji York Senior Software Engineer Zope Corporation

3 2

Zope Tests: 6 OK
by Zope Tests Summarizer 24 Feb '09

24 Feb '09

Summary of messages to the zope-tests list. Period Mon Feb 23 12:00:00 2009 UTC to Tue Feb 24 12:00:00 2009 UTC. There were 6 messages: 6 from Zope Tests. Tests passed OK --------------- Subject: OK : Zope-2.10 Python-2.4.6 : Linux From: Zope Tests Date: Mon Feb 23 20:24:31 EST 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-February/011175.html Subject: OK : Zope-2.11 Python-2.4.6 : Linux From: Zope Tests Date: Mon Feb 23 20:26:35 EST 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-February/011176.html Subject: OK : Zope-trunk Python-2.4.6 : Linux From: Zope Tests Date: Mon Feb 23 20:28:35 EST 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-February/011177.html Subject: OK : Zope-trunk Python-2.5.4 : Linux From: Zope Tests Date: Mon Feb 23 20:30:37 EST 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-February/011178.html Subject: OK : Zope-trunk-alltests Python-2.4.6 : Linux From: Zope Tests Date: Mon Feb 23 20:32:37 EST 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-February/011179.html Subject: OK : Zope-trunk-alltests Python-2.5.4 : Linux From: Zope Tests Date: Mon Feb 23 20:34:37 EST 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-February/011180.html

1 0

Re: [Zope-dev] [Checkins] SVN: zope.app.openidconsumer/ New library for OpenID auth in Zope 3
by Dan Korostelev 24 Feb '09

24 Feb '09

2009/2/24 Shane Hathaway <shane(a)hathawaymix.org>: > Log message for revision 97183: > New library for OpenID auth in Zope 3 > > > Changed: > A zope.app.openidconsumer/ Wow, that's great! Finally an OpenID auth plugin is being developed! Thank you :) I thought about publishing this myself many times, but now, as you are doing that, I'll be happy to help developing and testing this package. -- WBR, Dan Korostelev

3 3

Re: [Zope-dev] [Grok-dev] megrok.chameleon template engine
by Uli Fouquet 23 Feb '09

23 Feb '09

Hi there, Andreas Jung wrote: > Having little success with megrok.c right now. I created a new Grok > sandbox using grokproject and added megrok.chamelon to the eggs option. > Running buildout fails: > > ajung@suxmac2:~/sandboxes/chaeleon bin/buildout > Develop: '/Users/ajung/sandboxes/chaeleon/.' > Uninstalling app. > Unused options for buildout: 'download-directory'. > Updating eggbasket. > Installing app. > The version, 3.4, is not consistent with the requirement, 'zope.i18n>=3.5'. > While: > Installing app. > Error: Bad version 3.4 Yes, you need at least zope.i18n = 3.5, which can be set in buildout.cfg, as you know. This works here and can be pinned down in the buildout.cfg. Might help as a quick workaround. Can't say, where the zope.i18n=3.4 requirement comes from and I'll have a closer look at this. Best regards, -- Uli

1 0

zope2docs
by Andreas Jung 23 Feb '09

23 Feb '09

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 In preparation for the upcoming Zope 2.12 release we reorganized the Zope 2 documentation: - - all related documentation is now maintained a restructured text document in SVN: svn+ssh://svn.zope.org/repos/main/zope2docs - - The Zope Book, The Zope Developers Guide and some ZODB articles have been converted from STX to ReST - - The Zope 2.12 doc folder has been restified and is included within the zope2docs folder through a svn:external - - The Zope 2 specific documentation including releases notes will be generated in the future using Sphinx from 'zope2docs2' and published on docs.zope.org Thanks to Hanno and Tres for reSTifying the Zope book and the ZDG. Andreas - -- ZOPYX Ltd. & Co. KG - Charlottenstr. 37/1 - 72070 Tübingen - Germany Web: www.zopyx.com - Email: info(a)zopyx.com - Phone +49 - 7071 - 793376 Registergericht: Amtsgericht Stuttgart, Handelsregister A 381535 Geschäftsführer/Gesellschafter: ZOPYX Limited, Birmingham, UK - ------------------------------------------------------------------------ E-Publishing, Python, Zope & Plone development, Consulting -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (Darwin) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAkmgDVAACgkQCJIWIbr9KYyZMQCfShleZE5uqRL2f/UJvXxwkz8X QKoAmQHSNGC/mJMxxznzK79aAPidRc9k =Nw53 -----END PGP SIGNATURE-----

5 8

Re: [Zope-dev] SVN: Zope/trunk/ OFS.ObjectManager now fully implements the zope.container.IContainer interface and no longer just claims to do so. See the changelog for details and how backwards compatibility is handled.
by Tres Seaver 23 Feb '09

23 Feb '09

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hanno Schlichting wrote: > -- Acquisition has been made aware of __parent__ pointers. This allows > +- OFS.ObjectManager now fully implements the zope.container.IContainer > + interface. For the last Zope2 releases it already claimed to implement the > + interface, but didn't actually full-fill the interface contract. This means > + you can start using more commonly used Python idioms to access objects inside > + object managers. Complete dictionary-like access and container methods > + including iteration are now supported. For each class derived from > + ObjectManager you can use for any instance om: `om.keys()` instead of > + `om.objectIds()`, `om.values()` instead of `om.objectValues()`, but also > + `om.items()`, `ob.get('id')`, `ob['id']`, `'id' in om`, `iter(om)`, > + `len(om)`, `om['id'] = object()` instead of `om._setObject('id', object())` > + and `del ob['id']`. Using __setitem__ and __delitem__ has security implicatinos for untrusted code: how are you addressing them? Tres. - -- =================================================================== Tres Seaver +1 540-429-0999 tseaver(a)palladion.com Palladion Software "Excellence by Design" http://palladion.com -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFJosqw+gerLs4ltQ4RAsUBAJ9R2rL6Ook0qfmSCReEoKDbce5ZEgCeMqho fBNQ/GKp66MCvEhYh67/9lA= =/kCT -----END PGP SIGNATURE-----

2 3

Zope2 trunk: getting 'mkzopeinstance' / 'mkzeoinstance' working
by Tres Seaver 23 Feb '09

23 Feb '09

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 The scripts run, but produce instances which don't work, because they plug in the "base" python, rather than the "zopepy" one. Is anybody working on fixing this issue? Tres. - -- =================================================================== Tres Seaver +1 540-429-0999 tseaver(a)palladion.com Palladion Software "Excellence by Design" http://palladion.com -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFJotLv+gerLs4ltQ4RAnh2AJ9fubbzKYTXHOh82K0GVjPCGawDvACffhba cfyzkWDbyKBc2EchUY2Pw6k= =jiGZ -----END PGP SIGNATURE-----

1 0

Overhauling the Zope 2 presentation on zope.org
by Andreas Jung 23 Feb '09

23 Feb '09

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi there, because of the failure of the new.zope.org project I would like to put the hat on for reorganizing the Zope 2 presentation on zope.org. The goal is having up some pages with the downloads, basic pointers and links with the final release of Zope 2.12 later this year. There are basically two options: create a dedicated microsite (similar to grok.zope.org) or follow the Zope 3 approach on wiki.zope.org. Unless someone provides enough resources in helping, I would like to go with the wiki approach since it is much easier to handle. Volunteers that have the same interest in Zope 2 and getting this thing done are invited to join the effort. Based on the new.zope.org experienced I am interested in effective work and not so much in interested in discussions about briefs, mission statements and other less important stuff :-) Feel free to contact me in private. Cheers, Andreas - -- ZOPYX Ltd. & Co. KG - Charlottenstr. 37/1 - 72070 Tübingen - Germany Web: www.zopyx.com - Email: info(a)zopyx.com - Phone +49 - 7071 - 793376 Registergericht: Amtsgericht Stuttgart, Handelsregister A 381535 Geschäftsführer/Gesellschafter: ZOPYX Limited, Birmingham, UK - ------------------------------------------------------------------------ E-Publishing, Python, Zope & Plone development, Consulting -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (Darwin) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAkmdm8IACgkQCJIWIbr9KYzwSwCfWWTXgeM9KA+agDsKNbyHqGYQ V0YAoKahE2NBzvBWGruAjV2Fn09Zg+BD =Ra/x -----END PGP SIGNATURE-----

9 29

Retiring dev.zope.org aka /devhome wiki
by Andreas Jung 23 Feb '09

23 Feb '09

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi there, are there any objections to retire the old dev.zope.org site together with its wiki? I propose that we move the relevant parts to wiki.zope.org. The relevant information in the wiki as basically: SVN/CVS related docs + contributor/membership related information. This would be a long-hanging fruit for a volunteer :-) Andreas - -- ZOPYX Ltd. & Co. KG - Charlottenstr. 37/1 - 72070 Tübingen - Germany Web: www.zopyx.com - Email: info(a)zopyx.com - Phone +49 - 7071 - 793376 Registergericht: Amtsgericht Stuttgart, Handelsregister A 381535 Geschäftsführer/Gesellschafter: ZOPYX Limited, Birmingham, UK - ------------------------------------------------------------------------ E-Publishing, Python, Zope & Plone development, Consulting -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (Darwin) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAkmhgigACgkQCJIWIbr9KYyDXACePzYT2K2zIwP7XDm9L5QVzWsS e98AoJtOV4ba/uqjPIoqM63u4rdSgO3L =Ponu -----END PGP SIGNATURE-----

5 5