January 2001 - Zope-Dev

DTML Block Parsing - Patch #2
by Casey Duncan 24 Jan '01

24 Jan '01

I am sufficiently happy with my second patch to post it here for any takers. It should be applied to 2.3.0b2 or 2.3.0b1. It *has not* been tested against 2.2.5. The new patch supports nested comments so long as they are properly balanced inside the comment. As with my first patch it also allows you to create a custom DTML block tag that contains something other than valid DTML code. It now should support block continuation tages as well, although this had not been tested completely. Patch files are attached. Enjoy. -- | Casey Duncan | Kaivo, Inc. | cduncan(a)kaivo.com `------------------> *** DT_String.py~ Tue Dec 12 14:20:25 2000 --- DT_String.py Wed Jan 24 08:22:11 2001 *************** *** 272,313 **** sname=stag sstart=start sa=sargs ! while 1: l=tagre.search(text,start) if l < 0: self.parse_error('No closing tag', stag, text, sloc) try: tag, args, command, coname= self._parseTag(tagre,scommand,sa) ! except ParseError, m: self.parse_error(m[0],m[1], text, l) ! ! if command: ! start=l+len(tag) ! if hasattr(command, 'blockContinuations'): ! # New open tag. Need to find closing tag. ! start=self.parse_close(text, start, tagre, tag, l, ! command, args) else: ! # Either a continuation tag or an end tag ! section=self.SubTemplate(sname) ! section._v_blocks=section.blocks=self.parse(text[:l],sstart) ! section._v_cooked=None ! blocks.append((tname,sargs,section)) ! start=self.skip_eol(text,l+len(tag)) ! if coname: ! tname=coname ! sname=tag ! sargs=args ! sstart=start ! else: ! try: ! r=scommand(blocks) ! if hasattr(r,'simple_form'): r=r.simple_form ! result.append(r) ! except ParseError, m: self.parse_error(m[0],stag,text,l) ! return start parse_close__roles__=() def parse_close(self, text, start, tagre, stag, sloc, scommand, sa): --- 272,324 ---- sname=stag sstart=start sa=sargs ! # Determine if the tag wants dtml parsing ! parse_dtml = not hasattr(scommand, 'disable_dtml_block_parsing') + while 1: l=tagre.search(text,start) if l < 0: self.parse_error('No closing tag', stag, text, sloc) try: tag, args, command, coname= self._parseTag(tagre,scommand,sa) ! except ParseError, m: ! if parse_dtml: self.parse_error(m[0],m[1], text, l) ! else: start = l + 1 # Not parsing DTML: Skip malformed tags else: ! if command: ! start=l+len(tag) ! if hasattr(command, 'blockContinuations'): ! # New open tag. Need to find closing tag. ! try: start=self.parse_close(text, start, tagre, tag, l, ! command, args) ! except: ! if parse_dtml: raise ! else: ! # Either a continuation tag or an end tag ! if parse_dtml: ! section=self.SubTemplate(sname) ! section._v_blocks=section.blocks=self.parse(text[:l],sstart) ! else: ! section = String(text[sstart:l], __name__=sname) ! section._v_blocks = section.blocks = [section.raw] ! ! section._v_cooked=None ! blocks.append((tname,sargs,section)) ! start=self.skip_eol(text,l+len(tag)) ! if coname: ! tname=coname ! sname=tag ! sargs=args ! sstart=start ! else: ! try: ! r=scommand(blocks) ! if hasattr(r,'simple_form'): r=r.simple_form ! result.append(r) ! except ParseError, m: self.parse_error(m[0],stag,text,l) ! return start parse_close__roles__=() def parse_close(self, text, start, tagre, stag, sloc, scommand, sa): *** DT_Var.old Mon Jan 22 15:27:30 2001 --- DT_Var.py Mon Jan 22 15:28:14 2001 *************** *** 461,466 **** --- 461,467 ---- ''' name='comment' blockContinuations=() + disable_dtml_block_parsing = 1 def __init__(self, args, fmt=''): pass

1 0

ZSQL method - Can it 'resolve' a property value?
by Schmidt, Allen J. 24 Jan '01

24 Jan '01

I have an index_html which runs queries that count the number of items in a category and displays the number next to each category which is a link to the SearchResults page that will pass the name of the property to the next query. This is how I do the count part: (<dtml-in countAnnouncements><dtml-var announcements null=""></dtml-in>) I have a sql method for each count query and each uses a property (like announcements above) that contains a list of numbers (i.e. Announcements has: '001','002','003','004' ) So the query does a WHERE category IN ('001','002','003','004') statement by resolving the property and getting the list of numbers. This part works well. Now,... When I try to do the same thing on the SearchResults page, using a new sql method, I cannot get the property to resolve. I try using an attribute of the category for testing so it prompts for the category name when I test it. I use the MULTIPLE attribute with a DTML-SQLTEST to produce the "WHERE IN" type of query. I type in the name of the property that contains the list of numbers and all I get for the query is: .... WHERE category = ('nameOfProperty').... This makes less sense as I am describing it, but it may be clear to someone. Thanks Allen

1 0

Re: DTML block parsing - better then C/C++
by Jon Franz 24 Jan '01

24 Jan '01

This allowance for nested comments, as long as they are properly nested, is more then many laguages, such as C/C++, give you in the way of allowing nested comments - So I think its more then acceptable in its current form - good job! >OK, I have developed a new patch that almost completely fixes this >issue. In fact I am happier with it in general than my first patch. >There is only one flaw, although you can nest comments inside of one >another, and you can have any manner of broken dtml inside, if you open >another comment tag inside it, it must be properly balanced or you will >get a parse error. Here are some examples:

1 0

Re: [Zope-dev] dtml-in batching
by Tres Seaver 24 Jan '01

24 Jan '01

richard(a)bizarsoftware.com.au wrote: > richard(a)bizarsoftware.com.au wrote: > > > > The dtml-in batching mechanisms are quite difficult to debug - the DTML > > documentation I have has examples which break it and there's no indication > > of why. It turns out the DT_In renderwb() code gobbles all exceptions from > > the rendering of the previous and next blocks. I've hacked my code so that > > there's no try/except clause any more. I'm not sure what exception it's > > trying to catch, but could it perhaps be made a little more picky? > > And here's a diff - I'm pretty sure this was the intended behaviour... Please post this as a "Bug w/ patch" to the Collector: http://classic.zope.org:8080/Collector That way we don't lose your fix in the list traffic (losing it along with our marbles is another problem :) Tres. -- =============================================================== Tres Seaver tseaver(a)digicool.com Digital Creations "Zope Dealers" http://www.zope.org

4 6

DTML block parsing
by Casey Duncan 24 Jan '01

24 Jan '01

I am working on a custom DTML tag (that I may unleash on the world when finished) that has brought to my attention an interesting feature of the DTML parser: It preparses everything in the block(s) between the start and end tags before the document containing the code is committed. My tag is a little different in that I don't want to put DTML inside it, therefore this parsing is undesirable. There is however one built-in tag that this is true for as well: <dtml-comment>. Many a thread has been burned about that issue. I propose a change to DT_String to allow a tag to turn off this preparsing feature. It should be easy enough to implement by adding a class attribute to the tag class such as disable_dtml_block_parsing = 1. Is this abhorrent to anyone? If not, I will make a patch for DT_String to support this. The beneficial side affect would be that <dtml-comment> could be "fixed" so that its contents need not be parsable anymore, just like every other language I know of. -- | Casey Duncan | Kaivo, Inc. | cduncan(a)kaivo.com `------------------>

3 5

Re: [Zope-dev] CSS file serving
by Dieter Maurer 24 Jan '01

24 Jan '01

richard(a)bizarsoftware.com.au writes: > > http://www.zope.org/Members/haqa/ZStyleSheet > > Hrm - that's a little heavy for what I want - which is just an analog of > HTMLFile but for CSS files. That is, something I can add to my Python > product as an attribute. Definitely no management or other sorts of > trickiness required. Look at "App.ImageFile". If you are lucky, you can immediately use it to wrap your CSS files. If not, you should extend "OFS.content_types.guess_content_type" such that it recognizes the ".css" extension. Dieter

2 3

Membership and the 2.3 beta2 ... bug in the latter!
by Bill Anderson 23 Jan '01

23 Jan '01

Broke. broke badly. Not sur ecompletely why yet, but in 2.3b2, I can't move or copy a ZCatalog. There is one in the Membership interface, so as a result, no workie there. After deleteing int from teh membership interface folder, I get a traceback complaining about too many arguments in checkRoles (3 instead of 2). I haven't had time to dig into it yet, so I thought I would toss it up here so anyone with visibility to this issue can look at it. Bill Anderson

2 1

sql methods and the namespace stack
by Tim McLaughlin 23 Jan '01

23 Jan '01

Does anybody know why sql methods only search the request object instead of traversing the dtml namespace stack? TIA, Tim McLaughlin

2 1

Is manage_add for products broken?
by Jonothan Farr 23 Jan '01

23 Jan '01

Hello all, One of the Local File System users pointed out that calling manage_addLocalFS from dtml doesn't work. I did some checking and discovered that calling manage_addXXX doesn't work for any of the built-in products either. My testing was with 2.2.5. Am I crazy or didn't this work at one time? Is there a way to work around this? I couldn't find one. Thanks very much. Any help is appreciated. --jfarr

1 0

Specialist/Rack scalability
by Michael Bernstein 23 Jan '01

23 Jan '01

After comsidering the fedback I got from the previous 'Massive scalability thread, I decided to split my queries into two areas: Rack scalability and ZCatalog scalability. This email deals with the former. It seems clear that indexing and searching are more of a botleneck than storage/retreival. Nevertheless, so far I have not heard of anyone trying to store more than 60,000 objects in a rack. I need to know if there is any reason to suspect that storage (in the ZODB) or retreival performance would suffer if the number of objects was in the hundreds of thousands or even millions. Does anyone have anectodal or benchmark data that would suggest what happens with that many objects? Thanks, Michael Bernstein.

3 7